accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 21169: ACCUMULO-2770 Add utility to read local WAL
Date Mon, 12 May 2014 13:18:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21169/#review42686
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/21169/#comment76505>

    If this is the only documentation about the utility, should probably include the full
package name and how to run it e.g. bin/accumulo org.apache.accumulo.tserver.log.LocalWALRecovery



server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java
<https://reviews.apache.org/r/21169/#comment76504>

    Should probably log some info about where file is being copied to.  Its possible that
the utility may pick up a different config than the user expected and copy the files to an
unexpected location in dfs.


- kturner


On May 9, 2014, 5:35 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21169/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 5:35 p.m.)
> 
> 
> Review request for accumulo, Sean Busbey and Eric Newton.
> 
> 
> Bugs: ACCUMULO-2770
>     https://issues.apache.org/jira/browse/ACCUMULO-2770
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2770 Add utility to read local WAL
> 
> Forward port the upgrade code from 1.5.x into a separate utility so
> that a user can still read local WALs if they happen to be around.
> 
> Modify the utility to optionally accept values as command line options
> instead of searching around in the configuration settings.
> 
> commit 2db5ce6186e32c451328154b024951cc5090505f
> Author: Eric C. Newton <ecn@apache.org>
> Date:   Tue Jun 5 13:18:22 2012 +0000
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 60969bed6d67fd7677ed9349b9acc817b41456de

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21169/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message