accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 21043: ACCUMULO-1691 Update Thrift to 0.9.1
Date Sun, 11 May 2014 20:12:40 GMT


> On May 9, 2014, 5:19 p.m., Sean Busbey wrote:
> > which branch is this targeting?
> 
> Sean Busbey wrote:
>     nm. found 1.7.0 on ticket
> 
> Christopher Tubbs wrote:
>     The patch is a patch on 1.6.0 tag, and should apply cleanly to 1.6.1-SNAPSHOT or
master right now. I'd like to target this fix to a minor release after 1.6.0, called 1.7.0.
But that requires the currently marked 1.7.0 to be renamed 2.0.0.
> 
> Sean Busbey wrote:
>     Why not just target it for 2.0.0?

Because I think it's a change worth inclusion in a minor release, so that downstream maintainers
can provide a version as close to upstream as possible without variation, and because I hope
upstream Thrift will have the issue corrected by the time 2.0.0 is released.

In either case, we've not made a final decision about 2.0.0, so I'm just trying to ensure
the patch isn't fundamentally broken, so I can apply it downstream today, and we can figure
out where it fits later.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21043/#review42606
-----------------------------------------------------------


On May 2, 2014, 7:15 p.m., Christopher Tubbs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21043/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 7:15 p.m.)
> 
> 
> Review request for accumulo, Sean Busbey and kturner.
> 
> 
> Bugs: ACCUMULO-1691
>     https://issues.apache.org/jira/browse/ACCUMULO-1691
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Updates Thrift dependency to 0.9.1 with a hack to access a needed protected field.
> 
> 
> Diffs
> -----
> 
>   pom.xml 43aa5fb 
>   server/base/src/main/java/org/apache/accumulo/server/util/CustomNonBlockingServer.java
PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/util/TServerUtils.java 6d9e4c7

> 
> Diff: https://reviews.apache.org/r/21043/diff/
> 
> 
> Testing
> -------
> 
> mvn clean verify -Psunny
> 
> 
> Thanks,
> 
> Christopher Tubbs
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message