accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 21169: ACCUMULO-2770 Add utility to read local WAL
Date Thu, 08 May 2014 05:32:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21169/#review42461
-----------------------------------------------------------

Ship it!



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/21169/#comment76267>

    This description gets used in the generated help, right?
    
    The talk about what 1.5 does should be reworded for something like:
    
    "This property is only needed if Accumulo was upgraded from a 1.4 or earlier version.
In the upgrade to 1.5 this property is used to copy any earlier write ahead logs into DFS.
In 1.6+, this property is used by the LocalWALRecovery utility in the event that something
went wrong with that earlier upgrade. It is possible to specify a comma-separated list of
directories."
    
    This feels close to bikeshedding, so I'm willing to do this myself in a follow on patch
if you like.



server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java
<https://reviews.apache.org/r/21169/#comment76269>

    can you note that teh default is generated from the LOGGER_DIR property?



server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java
<https://reviews.apache.org/r/21169/#comment76268>

    nit whitespace


- Sean Busbey


On May 7, 2014, 11:55 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21169/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 11:55 p.m.)
> 
> 
> Review request for accumulo, Sean Busbey and Eric Newton.
> 
> 
> Bugs: ACCUMULO-2770
>     https://issues.apache.org/jira/browse/ACCUMULO-2770
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2770 Add utility to read local WAL
> 
> Forward port the upgrade code from 1.5.x into a separate utility so
> that a user can still read local WALs if they happen to be around.
> 
> Modify the utility to optionally accept values as command line options
> instead of searching around in the configuration settings.
> 
> commit 2db5ce6186e32c451328154b024951cc5090505f
> Author: Eric C. Newton <ecn@apache.org>
> Date:   Tue Jun 5 13:18:22 2012 +0000
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 60969bed6d67fd7677ed9349b9acc817b41456de

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21169/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message