accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 21169: ACCUMULO-2770 Add utility to read local WAL
Date Wed, 07 May 2014 23:32:38 GMT


> On May 7, 2014, 8:25 p.m., Sean Busbey wrote:
> > server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java,
lines 43-46
> > <https://reviews.apache.org/r/21169/diff/1/?file=576157#file576157line43>
> >
> >     If we keep the deletion, this needs to call out that that happens. If we don't,
it should include brief "and then delete the local files" instructions.
> >     
> >     Giving some idea of the maximum memory needed by this tool would be nice.
> >     
> >     Also a usage message that gives the utility description that's in the javadocs
would be nice.
> >

I'm not actually sure what the maximum memory needed by this tool would be. I don't know enough
about FSDataOutputStream to tell you if the memory needs to be at least as large as a single
key/value or the full file. I hope it's the former.

If you have a better usage message, I'll gladly take it. As is, we can defualt to JCommander's
parameter hints, and assume that if somebody is using this it's because they found the class
or something that told them to use this so they know what it is.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21169/#review42423
-----------------------------------------------------------


On May 7, 2014, 6:38 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21169/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 6:38 p.m.)
> 
> 
> Review request for accumulo, Sean Busbey and Eric Newton.
> 
> 
> Bugs: ACCUMULO-2770
>     https://issues.apache.org/jira/browse/ACCUMULO-2770
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2770 Add utility to read local WAL
> 
> Forward port the upgrade code from 1.5.x into a separate utility so
> that a user can still read local WALs if they happen to be around.
> 
> commit 2db5ce6186e32c451328154b024951cc5090505f
> Author: Eric C. Newton <ecn@apache.org>
> Date:   Tue Jun 5 13:18:22 2012 +0000
> 
> 
> Diffs
> -----
> 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalLogRecovery.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21169/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message