accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 21105: ACCUMULO-2776 adds rat plugin exclusion for build directories.
Date Tue, 06 May 2014 17:04:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21105/#review42307
-----------------------------------------------------------


See my -1 on the ticket. In summary: the rat check already ignores maven build directories,
and there is additional risk by introducing additional, unnecessary ignores.

- Christopher Tubbs


On May 6, 2014, 3:28 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21105/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 3:28 a.m.)
> 
> 
> Review request for accumulo and Christopher Tubbs.
> 
> 
> Bugs: ACCUMULO-2776
>     https://issues.apache.org/jira/browse/ACCUMULO-2776
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> adds an exclusion for target directories to the rat plugin configs
> 
> 
> Diffs
> -----
> 
>   pom.xml 5f1d20f 
>   server/pom.xml bd61fe6 
> 
> Diff: https://reviews.apache.org/r/21105/diff/
> 
> 
> Testing
> -------
> 
> run mvn package, verify that org.apache.rat:apache-rat-plugin:check fails.
> 
> apply change, verify target directories still present, verify that org.apache.rat:apache-rat-plugin:check
passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message