accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 21103: ACCUMULO-2775 set plugin configs that are specific to a module in plugins section
Date Tue, 06 May 2014 16:36:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21103/#review42296
-----------------------------------------------------------


See my -1 on the ticket. In summary: the rat check already ignores maven build directories,
and there is additional risk by introducing additional, unnecessary ignores.

- Christopher Tubbs


On May 6, 2014, 3:25 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21103/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 3:25 a.m.)
> 
> 
> Review request for accumulo and Christopher Tubbs.
> 
> 
> Bugs: ACCUMULO-2775
>     https://issues.apache.org/jira/browse/ACCUMULO-2775
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> For those modules that have plugin configurations specific to their runs, set the configurations
in build/plugins/plugin so that the configuration takes precedence over default configurations
set in parent poms.
> 
> 
> Diffs
> -----
> 
>   core/pom.xml 39de12a 
>   examples/simple/pom.xml 2b6ab69 
>   server/pom.xml bd61fe6 
>   start/pom.xml 5fc9346 
>   test/pom.xml ad60054 
> 
> Diff: https://reviews.apache.org/r/21103/diff/
> 
> 
> Testing
> -------
> 
> Verified that mvn org.apache.rat:apache-rat-plugin:check passed before and after change
on clean checkout.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message