Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0646510A8E for ; Tue, 8 Apr 2014 12:39:38 +0000 (UTC) Received: (qmail 2804 invoked by uid 500); 8 Apr 2014 12:39:37 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 2557 invoked by uid 500); 8 Apr 2014 12:39:35 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 2548 invoked by uid 99); 8 Apr 2014 12:39:34 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2014 12:39:34 +0000 Received: from localhost (HELO mail-lb0-f175.google.com) (127.0.0.1) (smtp-auth username ctubbsii, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2014 12:39:34 +0000 Received: by mail-lb0-f175.google.com with SMTP id w7so823479lbi.34 for ; Tue, 08 Apr 2014 05:39:32 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.134.230 with SMTP id pn6mr2586765lbb.37.1396960772094; Tue, 08 Apr 2014 05:39:32 -0700 (PDT) Received: by 10.114.96.138 with HTTP; Tue, 8 Apr 2014 05:39:32 -0700 (PDT) In-Reply-To: References: Date: Tue, 8 Apr 2014 08:39:32 -0400 Message-ID: Subject: Re: ACCUMULO-2145 fixVersion From: Christopher To: Accumulo Dev List Content-Type: text/plain; charset=UTF-8 When you say "make it a contrib", do you mean create a separate contrib repo for it? If so, that seems a bit overkill for that, to me, and seems to fit well into the existing test module. However, I can see merits in independent improvements post-release. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Tue, Apr 8, 2014 at 1:22 AM, Sean Busbey wrote: > I was hoping to make it a contrib. I have tests I run pre and post upgrade > to verify correctness and currently it spans versions. They don't currently > mix well with the rig from ACCUMULO-2145, but my plan was to work that out > after 1.6 gets out. > > I could instead put up the original versions that were specific to each of > 1.4, 1.5, and 1.6. However, I like having it independent so it can improve > and easily be used to test pervious releases if needed. > > -Sean > > On Sat, Apr 5, 2014 at 6:52 AM, Christopher wrote: > >> https://issues.apache.org/jira/browse/ACCUMULO-2145 does not have a >> fixVersion, but I happen to know that Keith has used the upgrade test >> to find and fix critical issues in 1.6.0 (because he described having >> done so in https://issues.apache.org/jira/browse/ACCUMULO-2520). It >> doesn't affect any Accumulo functioning, and enables better testing, >> so I don't see any reason to object to including it as tests. >> >> Does anybody have any issue committing it to 1.6.0-SNAPSHOT branch, so >> it's co-located with the version it is actually testing? >> >> -- >> Christopher L Tubbs II >> http://gravatar.com/ctubbsii >> > > > > -- > Sean