Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DDEB5F1D8 for ; Fri, 25 Apr 2014 16:36:02 +0000 (UTC) Received: (qmail 49693 invoked by uid 500); 25 Apr 2014 16:36:02 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 49621 invoked by uid 500); 25 Apr 2014 16:36:02 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 49611 invoked by uid 99); 25 Apr 2014 16:36:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 16:36:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 52A4B1D7110; Fri, 25 Apr 2014 16:35:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3073944433590707503==" MIME-Version: 1.0 Subject: Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6 From: keith@deenlo.com To: "accumulo" , "Sean Busbey" , keith@deenlo.com Date: Fri, 25 Apr 2014 16:35:56 -0000 Message-ID: <20140425163556.5212.79007@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/20636/ X-Sender: noreply@reviews.apache.org References: <20140425162852.25434.82469@reviews.apache.org> In-Reply-To: <20140425162852.25434.82469@reviews.apache.org> Reply-To: keith@deenlo.com X-ReviewRequest-Repository: accumulo --===============3073944433590707503== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20636/#review41480 ----------------------------------------------------------- Ship it! Ship It! - kturner On April 25, 2014, 4:28 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20636/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 4:28 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2726 > https://issues.apache.org/jira/browse/ACCUMULO-2726 > > > Repository: accumulo > > > Description > ------- > > restores things found missing by japi compliance checker > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java 9c39ea6 > core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java 30e47af > core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee5 > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java b9a7791 > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java 569a3b6 > core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 9d662f4 > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java 843f572 > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1 > core/src/main/java/org/apache/accumulo/core/client/impl/ActiveCompactionImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ActiveScanImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab > core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/SecurityOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsHelper.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java cfd9aa2 > core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c > core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java 15379af > core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java 9f0594a > core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java 16a8e02 > core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571 > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9 > core/src/main/java/org/apache/accumulo/core/client/mock/impl/MockTabletLocator.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 32136a8 > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 > server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java d63a63e > server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java cd59b78 > test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f > test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 > > Diff: https://reviews.apache.org/r/20636/diff/ > > > Testing > ------- > > unit tests pass. ITs passed. > > > Thanks, > > Sean Busbey > > --===============3073944433590707503==--