Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA6F411A10 for ; Fri, 25 Apr 2014 13:37:05 +0000 (UTC) Received: (qmail 90995 invoked by uid 500); 25 Apr 2014 13:37:04 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 90905 invoked by uid 500); 25 Apr 2014 13:37:04 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 90895 invoked by uid 99); 25 Apr 2014 13:37:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 13:37:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B45261D710A; Fri, 25 Apr 2014 13:36:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4095952743075280968==" MIME-Version: 1.0 Subject: Re: Review Request 20702: ACCUMULO-2733 Adds fromThrift to Credentials From: "Bill Havanki" To: "Bill Havanki" , "Sean Busbey" , "accumulo" Date: Fri, 25 Apr 2014 13:36:57 -0000 Message-ID: <20140425133657.25434.7489@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/20702/ X-Sender: "Bill Havanki" References: <20140425070713.5212.50147@reviews.apache.org> In-Reply-To: <20140425070713.5212.50147@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============4095952743075280968== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20702/#review41460 ----------------------------------------------------------- core/src/main/java/org/apache/accumulo/core/security/Credentials.java Nit: add @param and @return server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java This check for whether the token class is valid according to the current authenticator appears to be gone. (Maybe it's not needed and/or this has already been discussed.) - Bill Havanki On April 25, 2014, 3:07 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20702/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 3:07 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2733 > https://issues.apache.org/jira/browse/ACCUMULO-2733 > > > Repository: accumulo > > > Description > ------- > > adds fromThrift to Credentials, consolidates existing one-off deserializations. > > If ACCUMULO-2726 goes in first, I'll refactor this patch to just do the consolidation. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 > core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e > server/base/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java 3571d7f > server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001 > > Diff: https://reviews.apache.org/r/20702/diff/ > > > Testing > ------- > > unit tests passed. ITs running. > > > Thanks, > > Sean Busbey > > --===============4095952743075280968==--