Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============4858757536027502914=="
MIME-Version: 1.0
Subject: Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet
 migrations
 for offline tables.
From: "Sean Busbey" <sean@manvsbeard.com>
To: "Eric Newton" <eric.newton@gmail.com>, "Mike Drob" <mdrob@mdrob.com>
Cc: "Christopher Tubbs" <ctubbsii@apache.org>,
 "accumulo" <dev@accumulo.apache.org>, "Sean Busbey" <sean@manvsbeard.com>
Date: Thu, 24 Apr 2014 17:56:21 -0000
Message-ID: <20140424175621.21392.85368@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sean Busbey" <noreply@reviews.apache.org>
References: <20140424163103.5212.40963@reviews.apache.org>
In-Reply-To: <20140424163103.5212.40963@reviews.apache.org>
Reply-To: "Sean Busbey" <sean@manvsbeard.com>

--===============4858757536027502914==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On April 24, 2014, 4:31 p.m., Christopher Tubbs wrote:
> > src/server/pom.xml, line 94
> > <https://reviews.apache.org/r/20525/diff/3/?file=567770#file567770line94>
> >
> >     default scope is compile. omit this line, and make sure to run "mvn clean -P sortpom" to ensure pom changes are sorted.
> 
> Sean Busbey wrote:
>     we have a parent pom dependency management section that makes the scope test for guava.

the sortpom profile doesn't exist in 1.4.6-SNAPSHOT, but I'll keep this in mind when merging forward.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20525/#review41319
-----------------------------------------------------------


On April 24, 2014, 3:43 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20525/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 3:43 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2694
>     https://issues.apache.org/jira/browse/ACCUMULO-2694
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
>     
>     * Adds a funtional test that fails due to not rebalancing
>     * Fix master to clear migrations when it learns that a table has gone offline
>     * Update master to periodically clean up migrations for offline tables
>     * Fix balancers to make sure they log if they can't balance.
> 
> 
> Diffs
> -----
> 
>   src/server/pom.xml dbe4fb4 
>   src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 
>   test/system/auto/stress/migrations.py d07d7a8 
> 
> Diff: https://reviews.apache.org/r/20525/diff/
> 
> 
> Testing
> -------
> 
> Ran functional test without other changes -> failed. After full patch functional test passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


--===============4858757536027502914==--