Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B3D3511A82 for ; Tue, 15 Apr 2014 20:06:56 +0000 (UTC) Received: (qmail 47451 invoked by uid 500); 15 Apr 2014 20:06:55 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 47380 invoked by uid 500); 15 Apr 2014 20:06:55 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 47369 invoked by uid 99); 15 Apr 2014 20:06:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2014 20:06:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B30EE1D5F07; Tue, 15 Apr 2014 20:06:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5302735136371637472==" MIME-Version: 1.0 Subject: Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile. From: "Sean Busbey" To: "Josh Elser" Cc: "Sean Busbey" , "accumulo" , keith@deenlo.com Date: Tue, 15 Apr 2014 20:06:50 -0000 Message-ID: <20140415200650.14868.48278@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Busbey" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/20180/ X-Sender: "Sean Busbey" References: <20140415194758.19850.43234@reviews.apache.org> In-Reply-To: <20140415194758.19850.43234@reviews.apache.org> Reply-To: "Sean Busbey" X-ReviewRequest-Repository: accumulo --===============5302735136371637472== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 15, 2014, 7:47 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 86 > > > > > > will this cuase the test to fail if the file does not exist? > > Sean Busbey wrote: > yes, I presumed that was desirable? > > kturner wrote: > yes, want the test to fail if the file does not exist.... but I am not sure about hadoop return codes, I am also not sure if waitForStop checks return codes.... > > but this may be moot if the metadata table is scanned to find the filename... I confirmed that hadoop properly returns non-0 if the file doesn't exist, runOn returns it, and waitForStop checks it. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40447 ----------------------------------------------------------- On April 15, 2014, 7:38 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20180/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 7:38 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2654 > https://issues.apache.org/jira/browse/ACCUMULO-2654 > > > Repository: accumulo > > > Description > ------- > > Adds a simple utility for creating an empty RFile, leveraging existing code. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION > src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java 5374332 > test/system/auto/simple/recoverWithEmpty.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20180/diff/ > > > Testing > ------- > > tested basic error handling and help messages. tested creating file on hdfs and local file system. tested default codec, gz, and specifying the same codec as default. Used PrintInfo to verify generated files. > > ran new functional test. > > > Thanks, > > Sean Busbey > > --===============5302735136371637472==--