Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============9196356107990314281=="
MIME-Version: 1.0
Subject: Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating
 empty
 rfile.
From: keith@deenlo.com
To: "Josh Elser" <josh.elser@gmail.com>
Cc: "accumulo" <dev@accumulo.apache.org>, keith@deenlo.com,
 "Sean Busbey" <sean@manvsbeard.com>
Date: Tue, 15 Apr 2014 20:02:53 -0000
Message-ID: <20140415200253.14868.24895@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: noreply@reviews.apache.org
References: <20140415195134.19850.93433@reviews.apache.org>
In-Reply-To: <20140415195134.19850.93433@reviews.apache.org>
Reply-To: keith@deenlo.com

--===============9196356107990314281==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On April 15, 2014, 7:51 p.m., kturner wrote:
> > test/system/auto/simple/recoverWithEmpty.py, line 84
> > <https://reviews.apache.org/r/20180/diff/3/?file=558311#file558311line84>
> >
> >     If this file exist but it not referenced in the metadata table, then this test will not properly validate what its trying to... maybe the test should look in the metadata table to get the filename, or to just verify metadata refs the file
> 
> Sean Busbey wrote:
>     so a scan of the metadata table for the filename returning something would be sufficient?
>     
>     FWIW, I cribbed this from another test that uses printinfo to validate locality groups got properly serialized.

Thinking about this some more, Accumulo generates unique filenames for every file (even across tables and tablets). So F0000000.rf would only be used if the metadata table had not compacted :)    Should probably get the filename from the metadata table.


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20180/#review40448
-----------------------------------------------------------


On April 15, 2014, 7:38 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20180/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 7:38 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2654
>     https://issues.apache.org/jira/browse/ACCUMULO-2654
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Adds a simple utility for creating an empty RFile, leveraging existing code.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION 
>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java 5374332 
>   test/system/auto/simple/recoverWithEmpty.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20180/diff/
> 
> 
> Testing
> -------
> 
> tested basic error handling and help messages. tested creating file on hdfs and local file system. tested default codec, gz, and specifying the same codec as default. Used PrintInfo to verify generated files.
> 
> ran new functional test.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


--===============9196356107990314281==--