Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3DF7710388 for ; Wed, 9 Apr 2014 23:53:30 +0000 (UTC) Received: (qmail 17471 invoked by uid 500); 9 Apr 2014 23:53:29 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 17404 invoked by uid 500); 9 Apr 2014 23:53:29 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 17393 invoked by uid 99); 9 Apr 2014 23:53:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 23:53:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F40F81D5E30; Wed, 9 Apr 2014 23:53:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2316972983742617633==" MIME-Version: 1.0 Subject: Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile. From: "Vikram Srivastava" To: "Josh Elser" Cc: "Vikram Srivastava" , "Sean Busbey" , "accumulo" Date: Wed, 09 Apr 2014 23:53:24 -0000 Message-ID: <20140409235324.847.20296@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vikram Srivastava" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/20180/ X-Sender: "Vikram Srivastava" References: <20140409213730.20524.44796@reviews.apache.org> In-Reply-To: <20140409213730.20524.44796@reviews.apache.org> Reply-To: "Vikram Srivastava" X-ReviewRequest-Repository: accumulo --===============2316972983742617633== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 9, 2014, 9:37 p.m., Vikram Srivastava wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, lines 59-66 > > > > > > We can first validate all args, and then create them in 2nd pass to ensure some files don't get created. > > Sean Busbey wrote: > Worth switching to Guava's Precondition? core doesn't have a Guava dep in this branch. I'll defer to you to use Precondition here. My concern was only that if user enters "f1.rf f2.rf f3.nrf", it's more user friendly to give error in the beginning rather than aborting with an error in the middle. - Vikram ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review39937 ----------------------------------------------------------- On April 9, 2014, 9:28 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20180/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 9:28 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2654 > https://issues.apache.org/jira/browse/ACCUMULO-2654 > > > Repository: accumulo > > > Description > ------- > > Adds a simple utility for creating an empty RFile, leveraging existing code. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION > src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java 5374332 > > Diff: https://reviews.apache.org/r/20180/diff/ > > > Testing > ------- > > tested basic error handling and help messages. tested creating file on hdfs and local file system. tested default codec, gz, and specifying the same codec as default. Used PrintInfo to verify generated files. > > > Thanks, > > Sean Busbey > > --===============2316972983742617633==--