Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 815AF118C0 for ; Wed, 2 Apr 2014 07:50:57 +0000 (UTC) Received: (qmail 72938 invoked by uid 500); 2 Apr 2014 07:50:57 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 72690 invoked by uid 500); 2 Apr 2014 07:50:54 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 72671 invoked by uid 99); 2 Apr 2014 07:50:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2014 07:50:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7BAF81C0298; Wed, 2 Apr 2014 07:50:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8643957077606659384==" MIME-Version: 1.0 Subject: Re: Review Request 19804: ACCUMULO-2519 Aborts upgrade if there are Fate transactions from an old version. From: "Sean Busbey" To: keith@deenlo.com Cc: "Mike Drob" , "accumulo" , "Bill Havanki" , "Sean Busbey" Date: Wed, 02 Apr 2014 07:50:43 -0000 Message-ID: <20140402075043.16750.50116@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Busbey" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/19804/ X-Sender: "Sean Busbey" References: <20140402060618.16750.59060@reviews.apache.org> In-Reply-To: <20140402060618.16750.59060@reviews.apache.org> Reply-To: "Sean Busbey" X-ReviewRequest-Repository: accumulo --===============8643957077606659384== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19804/ ----------------------------------------------------------- (Updated April 2, 2014, 7:50 a.m.) Review request for accumulo and kturner. Changes ------- updated docs to call out that completed fate operations will block and upgrade and can be deleted. Bugs: ACCUMULO-2519 https://issues.apache.org/jira/browse/ACCUMULO-2519 Repository: accumulo Description ------- Adds "make sure Fate has no outstanding items" to the upgrade instructions. Makes sure the master and tabletservers don't take upgrade steps if they see fate ops waiting. Diffs (updated) ----- README 115a9b7 server/src/main/java/org/apache/accumulo/server/Accumulo.java 99ec7e4 server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864 server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java d76946d server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java 7328a55 Diff: https://reviews.apache.org/r/19804/diff/ Testing ------- Took a 1.4.5-SNAP cluster * loaded test data in a variety of table configs * alternate table creation and deletion * load additional table to cause !METADATA churn * shutdown cluster uncleanly * verified waiting Fate transactions (table deletion at success status) * verified waiting local WALs * verified waiting local WALs include !METADATA table (via LogReader) * verified /accumulo/version showed 4 * Start upgrade to 1.5.2-SNAP * verified errors showing no upgrade and to go back to docs in: monitor, master logs, tabletserver logs * verified same waiting Fate transactions * verified same waiting local WALs * verified /accumulo/version showed 4 * Cleared Fate operations * Start upgrade to 1.5.2-SNAP * wait a terrifying long amount of time, check on progress via local logs * verify no errors shown for upgrade * verified WALs copied to HDFS * verified /accumulo/version showed 5 * verified monitor showed normal start up * wait for all tablets to be hosted * verify test data Thanks, Sean Busbey --===============8643957077606659384==--