accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 20790: ACCUMULO-2742 offset history command by one
Date Mon, 28 Apr 2014 22:30:52 GMT


> On April 28, 2014, 6:29 p.m., Christopher Tubbs wrote:
> > Ship It!

Actually... before you ship it, it'd be nice if there were a small comment explaining the
assume usage in the event expansion test... just to explain why it doesn't work under some
Eclipse environments.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20790/#review41644
-----------------------------------------------------------


On April 28, 2014, 6:11 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20790/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 6:11 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2742
>     https://issues.apache.org/jira/browse/ACCUMULO-2742
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2742 offset history command by one
> 
> The history entries returned by the history command are 0-indexed,
> while the history expansion is 1-indexed. We need to offset the index
> when we print it so that users can accurately use event expansion.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/util/shell/commands/HistoryCommand.java
9531d903aca834ab3b70650824023061e7e788d9 
>   core/src/test/java/org/apache/accumulo/core/util/shell/command/HistoryCommandTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20790/diff/
> 
> 
> Testing
> -------
> 
> New unit test. Verified on cluster deployment.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message