accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 20790: ACCUMULO-2742 offset history command by one
Date Mon, 28 Apr 2014 21:14:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20790/
-----------------------------------------------------------

(Updated April 28, 2014, 9:14 p.m.)


Review request for accumulo.


Changes
-------

Use platform independent new-line, because I think OS X behaves funny with JLine.


Bugs: ACCUMULO-2742
    https://issues.apache.org/jira/browse/ACCUMULO-2742


Repository: accumulo


Description
-------

ACCUMULO-2742 offset history command by one

The history entries returned by the history command are 0-indexed,
while the history expansion is 1-indexed. We need to offset the index
when we print it so that users can accurately use event expansion.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/HistoryCommand.java 9531d903aca834ab3b70650824023061e7e788d9

  core/src/test/java/org/apache/accumulo/core/util/shell/command/HistoryCommandTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/20790/diff/


Testing
-------

New unit test. Verified on cluster deployment.


Thanks,

Mike Drob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message