accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 20705: ACCUMULO-2635 - ZooCacheFactory
Date Fri, 25 Apr 2014 16:11:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20705/
-----------------------------------------------------------

(Updated April 25, 2014, 12:11 p.m.)


Review request for accumulo.


Changes
-------

Functional tests pass as well.


Bugs: ACCUMULO-2635
    https://issues.apache.org/jira/browse/ACCUMULO-2635


Repository: accumulo


Description
-------

This diff introduces a ZooCacheFactory class to centralize and maximize reuse of ZooCache
instances and to facilitate testing. The caching mechanism formerly in ZooCache was moved
to the factory; also, the separate caching mechanism in ServerClient was removed in favor
of the factory.

To make reviewing easier: Start with the fate classes, and then move on to the rest. Three
of the remaining classes - RootTabletLocator, ZooKeeperInstance, and ZookeeperLockChecker
- were changed more than the others to explore writing unit tests that take advantage of ZooCacheFactory.
The new unit tests are also included here.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java 43b315df496b3cbb92495a0b4a4019315b0ff9b0

  core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java f80eee511db1fddb9a18bfd4c514c57cd3be7ce9

  core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java 01e4b95386c48ce7ba36559928e82e7aa0abd4f2

  core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java c134c0492b911e63ba731f7d4f5b37ae0b57e9cf

  core/src/main/java/org/apache/accumulo/core/client/impl/RootTabletLocator.java 1224207f8838fe9705cb3f60fdaefb51e357504f

  core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java bf3e1bc063838482da6c95b6f5693a23446d6f60

  core/src/main/java/org/apache/accumulo/core/client/impl/Tables.java 5988bda3b2853ab6113b1c8b71d632aa323ac995

  core/src/main/java/org/apache/accumulo/core/client/impl/ZookeeperLockChecker.java 85bd171f7a87a60ed340b6e51c3c63f967d7ed46

  core/src/test/java/org/apache/accumulo/core/client/ZooKeeperInstanceTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/impl/RootTabletLocatorTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/impl/ZookeeperLockCheckerTest.java PRE-CREATION

  fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java e793a696b66f1cf6fa160bd2829f6ab5b3ae0b67

  fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCacheFactory.java PRE-CREATION

  fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java 03e159f38e0d0abd32d5361a5a4b07648d7926e1

  fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheFactoryTest.java PRE-CREATION

  server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstance.java 620188ccbec40ff5c669cd3ceb7872ca91fe7fd4

  server/base/src/main/java/org/apache/accumulo/server/conf/NamespaceConfiguration.java 99532ca0ef29b45fe406ab631510a04c26398505

  server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java c134e315ad73f5e4034b63d2de3697b64fce7f00

  server/base/src/main/java/org/apache/accumulo/server/conf/ZooConfiguration.java 0c03aaca897cfbc9b58113b1b5d480469b810509


Diff: https://reviews.apache.org/r/20705/diff/


Testing (updated)
-------

Unit tests pass. Functional tests pass.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message