accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 20702: ACCUMULO-2733 Adds fromThrift to Credentials
Date Fri, 25 Apr 2014 14:53:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20702/
-----------------------------------------------------------

(Updated April 25, 2014, 2:53 p.m.)


Review request for accumulo.


Changes
-------

fixed javadoc


Bugs: ACCUMULO-2733
    https://issues.apache.org/jira/browse/ACCUMULO-2733


Repository: accumulo


Description
-------

adds fromThrift to Credentials, consolidates existing one-off deserializations.

If ACCUMULO-2726 goes in first, I'll refactor this patch to just do the consolidation.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
  core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
  server/base/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java 3571d7f

  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java c2a7001


Diff: https://reviews.apache.org/r/20702/diff/


Testing (updated)
-------

unit tests passed. ITs passed. No new warnings show up via build.


Thanks,

Sean Busbey


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message