accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 20702: ACCUMULO-2733 Adds fromThrift to Credentials
Date Fri, 25 Apr 2014 14:50:49 GMT


> On April 25, 2014, 1:36 p.m., Bill Havanki wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Credentials.java, line 94
> > <https://reviews.apache.org/r/20702/diff/1/?file=568323#file568323line94>
> >
> >     Nit: add @param and @return

fixed


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20702/#review41460
-----------------------------------------------------------


On April 25, 2014, 7:07 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20702/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 7:07 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2733
>     https://issues.apache.org/jira/browse/ACCUMULO-2733
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> adds fromThrift to Credentials, consolidates existing one-off deserializations.
> 
> If ACCUMULO-2726 goes in first, I'll refactor this patch to just do the consolidation.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   server/base/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java
3571d7f 
>   server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java
c2a7001 
> 
> Diff: https://reviews.apache.org/r/20702/diff/
> 
> 
> Testing
> -------
> 
> unit tests passed. ITs running.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message