accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
Date Thu, 24 Apr 2014 19:25:55 GMT


> On April 24, 2014, 4:31 p.m., Christopher Tubbs wrote:
> > src/server/pom.xml, line 94
> > <https://reviews.apache.org/r/20525/diff/3/?file=567770#file567770line94>
> >
> >     default scope is compile. omit this line, and make sure to run "mvn clean -P
sortpom" to ensure pom changes are sorted.
> 
> Sean Busbey wrote:
>     we have a parent pom dependency management section that makes the scope test for
guava.
> 
> Sean Busbey wrote:
>     the sortpom profile doesn't exist in 1.4.6-SNAPSHOT, but I'll keep this in mind when
merging forward.
> 
> Christopher Tubbs wrote:
>     FYI, it's bad practice to put scopes in the dependencyManagement sections. It's best
to use the default scope there, and specify a more specific scope in the child POMs, where
it's actually used.

I agree. I'm just trying to limit the scope for this ticket.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20525/#review41319
-----------------------------------------------------------


On April 24, 2014, 3:43 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20525/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 3:43 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2694
>     https://issues.apache.org/jira/browse/ACCUMULO-2694
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
>     
>     * Adds a funtional test that fails due to not rebalancing
>     * Fix master to clear migrations when it learns that a table has gone offline
>     * Update master to periodically clean up migrations for offline tables
>     * Fix balancers to make sure they log if they can't balance.
> 
> 
> Diffs
> -----
> 
>   src/server/pom.xml dbe4fb4 
>   src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
02a4e89 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java
4826097 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java
ad62360 
>   test/system/auto/stress/migrations.py d07d7a8 
> 
> Diff: https://reviews.apache.org/r/20525/diff/
> 
> 
> Testing
> -------
> 
> Ran functional test without other changes -> failed. After full patch functional test
passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message