accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6
Date Thu, 24 Apr 2014 16:50:05 GMT


> On April 23, 2014, 11:24 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java,
line 62
> > <https://reviews.apache.org/r/20636/diff/1/?file=566298#file566298line62>
> >
> >     this class is completely new in 1.6.0... if this were to make it into RC4, then
this class could just start off in an impl package
> 
> Sean Busbey wrote:
>     Couldn't move it out of the package because it needs to access package-private parts
of TableOperationsImpl. Couldn't make it package-private because impl/ConnectorImpl needs
to access it.
>     
>     So ATM, still marked as deprecated in the version it was introduced. Should I add
a javadoc (or non-javadoc comment) that explains this?
> 
> kturner wrote:
>     What about doing the following?
>     
>      1 Move *Impl classes to impl package
>      2 Create *Impl classes that extent impl.*Impl classes and expose whatever is public
>     
>     This way internal code does not need to instantiate deprecated code AND NamespaceOperationsImpl
can be deleted.   
>     
>     Christopher did something similar when deprecating the mapreduce util package.
> 
> Christopher Tubbs wrote:
>     I used delegation, not extension, but yeah, similar.
> 
> kturner wrote:
>     there is an advantage to delegation over extension.   Delegation makes its easy to
freeze the deprecated API.  W/ extension adding a public method in a impl.*Impl class will
add it to the *Impl class that extends it.
> 
> Sean Busbey wrote:
>     I'm already mostly done with the extension version. Does anyone feel strongly about
using delegation?

I slightly prefer delegation.  But the entire class is deperecated, so even if new methods
come into existance it probably does not matter too much (its just kinda screwy).


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------


On April 24, 2014, 7:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 7:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java
f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java
b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java
569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java
9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java
843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1

>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 7d9d3ab

>   core/src/main/java/org/apache/accumulo/core/client/impl/NamespaceOperationsHelper.java
PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java
cfd9aa2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c

>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java
15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java
9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java
16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571

>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9

>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
>   test/compat/japi-compliance/japi-accumulo-1.5.xml 9e6f47f 
>   test/compat/japi-compliance/japi-accumulo-1.6.xml 36553b8 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. ITs passed.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message