accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 20636: ACCUMULO-2726 restore binary compatibility 1.5 -> 1.6
Date Wed, 23 Apr 2014 23:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20636/#review41240
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74679>

    why deprecate this method when the entire class is deperecated?



core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java
<https://reviews.apache.org/r/20636/#comment74677>

    this class is completely new in 1.6.0... if this were to make it into RC4, then this class
could just start off in an impl package



core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java
<https://reviews.apache.org/r/20636/#comment74680>

    I assume this class is also completely new in 1.6.0


- kturner


On April 23, 2014, 10:34 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20636/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 10:34 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2726
>     https://issues.apache.org/jira/browse/ACCUMULO-2726
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> restores things found missing by japi compliance checker
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperationsImpl.java
f80eee5 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsHelper.java
b9a7791 
>   core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperationsImpl.java
569a3b6 
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java
9d662f4 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsHelper.java
843f572 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 3d69cc1

>   core/src/main/java/org/apache/accumulo/core/client/mock/MockInstanceOperations.java
15379af 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockNamespaceOperations.java
9f0594a 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockSecurityOperations.java
16a8e02 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java 2bc9436 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571

>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTabletLocator.java 6bd01a9

>   core/src/main/java/org/apache/accumulo/core/security/Credentials.java 5afc6e8 
>   core/src/test/java/org/apache/accumulo/core/security/CredentialsTest.java 4f8079e 
> 
> Diff: https://reviews.apache.org/r/20636/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. waiting on ITs.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message