accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 20465: ACCUMULO-2343 - AsyncSocketAppender
Date Tue, 22 Apr 2014 14:30:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20465/
-----------------------------------------------------------

(Updated April 22, 2014, 10:30 a.m.)


Review request for accumulo and Josh Elser.


Changes
-------

MonitorLoggingIT improvements based on Josh's feedback.


Bugs: ACCUMULO-2343
    https://issues.apache.org/jira/browse/ACCUMULO-2343


Repository: accumulo


Description
-------

AsyncSocketAppender is a Log4J AsyncAppender with its own internal SocketAppender. Configuration
for either appender can be set on the AsyncSocketAppender itself. An AsyncSocketAppender can
be configured using a Log4J properties file, while an ordinary AsyncAppender cannot.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java PRE-CREATION

  test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java d9bed7f 
  test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java PRE-CREATION

  test/src/test/resources/conf/generic_logger.xml PRE-CREATION 
  test/src/test/resources/conf/monitor_logger.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/20465/diff/


Testing
-------

Unit test created and passed. Also used main() method to send log messages to a running Log4J
SimpleSocketServer instance.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message