accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 20465: ACCUMULO-2343 - AsyncSocketAppender
Date Tue, 22 Apr 2014 14:06:17 GMT


> On April 21, 2014, 9:08 p.m., Josh Elser wrote:
> > Did you also verify that you can run an instance using only the log4j.properties?
Perhaps wrapping back around to earlier comments, have you also verified that updates to log4j.properties
reload the logging backend? I'm not sure if log4j configures and watches log4j.properties
by default. Also, what happens if I have both *_logger.xml files and log4j.properties files
on the classpath which conflict each other (one sets some logger to WARN and the other to
DEBUG) -- which one will actually be set?
> 
> Bill Havanki wrote:
>     I didn't perform those higher-order tests at this time because ACCUMULO-2383 covers
integration testing of this appender with the rest of the system. This is a good list of things
to ensure, though.
>     
>     From looking forward, I know that the Accumulo and MonitorLog4jWatcher classes will
need to be updated to use either a Log4j DOMConfigurator or PropertyConfigurator, depending
on the type of configuration file. PropertyConfigurator can set a watch on a file.
>     
>     The Accumulo class specifically looks for *_logger.xml files now, so we should be
free to prioritize either properties or XML files in that logic. (If it were left to Log4j's
default search order, then it would only look for log4j.properties.)

Gotcha, wasn't sure what all was going to get rolled into this ticket. Sounds good to punt
on the integration piece for 2383. I don't think any of the integration work will require
additional upstream changes (I hope?). I'll try to keep these things in mind when the big-picture
changes get picked up.


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20465/#review40942
-----------------------------------------------------------


On April 18, 2014, 7:14 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20465/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 7:14 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2343
>     https://issues.apache.org/jira/browse/ACCUMULO-2343
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> AsyncSocketAppender is a Log4J AsyncAppender with its own internal SocketAppender. Configuration
for either appender can be set on the AsyncSocketAppender itself. An AsyncSocketAppender can
be configured using a Log4J properties file, while an ordinary AsyncAppender cannot.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java d9bed7f

>   test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java PRE-CREATION

>   test/src/test/resources/conf/generic_logger.xml PRE-CREATION 
>   test/src/test/resources/conf/monitor_logger.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20465/diff/
> 
> 
> Testing
> -------
> 
> Unit test created and passed. Also used main() method to send log messages to a running
Log4J SimpleSocketServer instance.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message