accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
Date Mon, 21 Apr 2014 21:36:49 GMT


> On April 21, 2014, 9:22 p.m., Josh Elser wrote:
> > src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java,
line 321
> > <https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line321>
> >
> >     Seems like this could get rather spammy. If we have no tservers, we *know* that
things are already bad, probably don't need to be re-WARN'ed.

a balancer's notion of "there are online tservers" might differ from other points in the system,
so I think it's still worth calling out if a balancer thinks there are none.

Take a look at the change and let me know if this sounds sufficiently fixed? It'll only message
if balance calls fail for one contiguous minute, and only repeat the message once per minute.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20525/#review40950
-----------------------------------------------------------


On April 21, 2014, 9:32 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20525/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 9:32 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2694
>     https://issues.apache.org/jira/browse/ACCUMULO-2694
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
>     
>     * Adds a funtional test that fails due to not rebalancing
>     * Fix master to clear migrations when it learns that a table has gone offline
>     * Update master to periodically clean up migrations for offline tables
>     * Fix balancers to make sure they log if they can't balance.
> 
> 
> Diffs
> -----
> 
>   src/server/pom.xml dbe4fb4 
>   src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
02a4e89 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java
4826097 
>   src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java
ad62360 
>   test/system/auto/stress/migrations.py d07d7a8 
> 
> Diff: https://reviews.apache.org/r/20525/diff/
> 
> 
> Testing
> -------
> 
> Ran functional test without other changes -> failed. After full patch functional test
passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message