accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 20523: Initial refactoring, just structural updates.
Date Mon, 21 Apr 2014 19:14:15 GMT


> On April 21, 2014, 6 p.m., Mike Drob wrote:
> > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java,
line 39
> > <https://reviews.apache.org/r/20523/diff/1/?file=563129#file563129line39>
> >
> >     Builder.
> 
> Eric Newton wrote:
>     I don't know what it would accomplish.  It's a read-only record that is constructed
in 2 places.

Knee-jerk reaction to lots of constructor args. Might help with testability to have a builder
+ private fields + getters. Feel free to drop or create a follow-on as appropriate.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20523/#review40898
-----------------------------------------------------------


On April 21, 2014, 5:23 p.m., Eric Newton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20523/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 5:23 p.m.)
> 
> 
> Review request for accumulo, Bill Havanki and kturner.
> 
> 
> Bugs: ACCUMULO-2041
>     https://issues.apache.org/jira/browse/ACCUMULO-2041
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Initial refactoring of tablet.  Extract inner classes, make members private and final
as much as possible, group tablet-related classes into o.a.a.tserver.tablet.
> 
> 
> Diffs
> -----
> 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95

>   server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7

>   server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5

>   server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java
e13594d 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
f26c74b 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
871f4ae 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletClosedException.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletMemory.java PRE-CREATION

>   server/tserver/src/test/java/org/apache/accumulo/tserver/CountingIteratorTest.java
c5c3316 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/RootFilesTest.java f216e93

> 
> Diff: https://reviews.apache.org/r/20523/diff/
> 
> 
> Testing
> -------
> 
> Unit and IT's
> 
> 
> Thanks,
> 
> Eric Newton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message