accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 20465: ACCUMULO-2343 - AsyncSocketAppender
Date Fri, 18 Apr 2014 13:46:37 GMT


> On April 17, 2014, 5:34 p.m., Josh Elser wrote:
> > Are you planning to wire this up in pieces? It would be nice to be able to see how
this changes the Accumulo.init(...) method which currently sets up logging for each process.
> 
> Bill Havanki wrote:
>     I'll take a look at init() to see how it fits in. My hope was that it would merely
be a substitute merging the current "ASYNC" and "N1" appenders in the example configs. Now
that I'm writing this, I think I remember seeing direct reference to the "ASYNC" name in code.
I'll check.

>From what I can see, Accumulo.init() doesn't need to change at all if a user opts for
this appender. The same logger parameters, constructed from the system properties that init()
sets, are passed to a socket appender in either case: for the current setup, to a socket appender;
for this one, through the new appender to its embedded socket appender.

Accumulo.init() does need to change to look for properties files as well as XML files, but
I think that's for ACCUMULO-2383 or -2373.

MonitorLog4jWatcher currently specifically looks for an "ASYNC" appender to close it down
in case the logging info in ZK disappears. That should work the same with the new appender,
provided of course that it's also named "ASYNC". Maybe there's a way to avoid hardcoding that
name.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20465/#review40698
-----------------------------------------------------------


On April 17, 2014, 5:06 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20465/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 5:06 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2343
>     https://issues.apache.org/jira/browse/ACCUMULO-2343
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> AsyncSocketAppender is a Log4J AsyncAppender with its own internal SocketAppender. Configuration
for either appender can be set on the AsyncSocketAppender itself. An AsyncSocketAppender can
be configured using a Log4J properties file, while an ordinary AsyncAppender cannot.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/20465/diff/
> 
> 
> Testing
> -------
> 
> Unit test created and passed. Also used main() method to send log messages to a running
Log4J SimpleSocketServer instance.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message