accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Newton" <eric.new...@gmail.com>
Subject Re: Review Request 20419: ACCUMULO-2654 Add utility to create empty rfile (1.5)
Date Wed, 16 Apr 2014 17:34:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20419/#review40573
-----------------------------------------------------------

Ship it!


Ship It!

- Eric Newton


On April 16, 2014, 5:29 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20419/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 5:29 p.m.)
> 
> 
> Review request for accumulo and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2654
>     https://issues.apache.org/jira/browse/ACCUMULO-2654
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> merged previous tool to 1.5, then updated to use jcommander. This is just a quick check
on the compromises needed to work with jcommander, like only listing codecs on error.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION

>   core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java 5374332

>   test/system/auto/simple/recoverWithEmpty.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20419/diff/
> 
> 
> Testing
> -------
> 
> ran functional test. tried creating files with each codec.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message