accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.
Date Tue, 15 Apr 2014 19:59:29 GMT


> On April 15, 2014, 7:47 p.m., kturner wrote:
> > test/system/auto/simple/recoverWithEmpty.py, line 86
> > <https://reviews.apache.org/r/20180/diff/3/?file=558311#file558311line86>
> >
> >     will this cuase the test to fail if the file does not exist?
> 
> Sean Busbey wrote:
>     yes, I presumed that was desirable?

yes, want the test to fail if the file does not exist.... but I am not sure about hadoop return
codes, I am also not sure if waitForStop checks return codes....

but this may be moot if the metadata table is scanned to find the filename...


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20180/#review40447
-----------------------------------------------------------


On April 15, 2014, 7:38 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20180/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 7:38 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2654
>     https://issues.apache.org/jira/browse/ACCUMULO-2654
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Adds a simple utility for creating an empty RFile, leveraging existing code.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION

>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java 5374332

>   test/system/auto/simple/recoverWithEmpty.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20180/diff/
> 
> 
> Testing
> -------
> 
> tested basic error handling and help messages. tested creating file on hdfs and local
file system. tested default codec, gz, and specifying the same codec as default. Used PrintInfo
to verify generated files.
> 
> ran new functional test.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message