accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikram Srivastava" <vicky...@gmail.com>
Subject Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.
Date Wed, 09 Apr 2014 23:53:24 GMT


> On April 9, 2014, 9:37 p.m., Vikram Srivastava wrote:
> > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, lines
59-66
> > <https://reviews.apache.org/r/20180/diff/2/?file=554090#file554090line59>
> >
> >     We can first validate all args, and then create them in 2nd pass to ensure some
files don't get created.
> 
> Sean Busbey wrote:
>     Worth switching to Guava's Precondition? core doesn't have a Guava dep in this branch.

I'll defer to you to use Precondition here. My concern was only that if user enters "f1.rf
f2.rf f3.nrf", it's more user friendly to give error in the beginning rather than aborting
with an error in the middle.


- Vikram


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20180/#review39937
-----------------------------------------------------------


On April 9, 2014, 9:28 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20180/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 9:28 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2654
>     https://issues.apache.org/jira/browse/ACCUMULO-2654
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Adds a simple utility for creating an empty RFile, leveraging existing code.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION

>   src/core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java 5374332

> 
> Diff: https://reviews.apache.org/r/20180/diff/
> 
> 
> Testing
> -------
> 
> tested basic error handling and help messages. tested creating file on hdfs and local
file system. tested default codec, gz, and specifying the same codec as default. Used PrintInfo
to verify generated files.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message