accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 20177: ACCUMULO-2212 - ZooReaderWriterFactory, version 2
Date Wed, 09 Apr 2014 23:04:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20177/
-----------------------------------------------------------

(Updated April 9, 2014, 7:04 p.m.)


Review request for accumulo.


Changes
-------

Functional tests passed.


Bugs: ACCUMULO-2212
    https://issues.apache.org/jira/browse/ACCUMULO-2212


Repository: accumulo


Description
-------

The o.a.a.server.zookeeper.ZooReaderWriter class is mostly copied into a new ZooReaderWriterFactory
class. Users of the factory can work directly with FATE ZooReaderWriter instances, instead
of those of the server type, which is no longer needed. The logic for building instances from
site configuration data is in the factory.

As part of this change, the invocation handler used to retry ZK calls on connection loss is
refactored into a new RetryingInvocationHandler.


Diffs
-----

  fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryingInvocationHandler.java PRE-CREATION

  fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriter.java 2a327b0 
  fate/src/test/java/org/apache/accumulo/fate/zookeeper/RetryingInvocationHandlerTest.java
PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/zookeeper/ZooReaderWriterFactory.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/20177/diff/


Testing (updated)
-------

Unit tests pass; functional tests pass.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message