accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 20087: Move shell into a separate module
Date Mon, 07 Apr 2014 20:37:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20087/
-----------------------------------------------------------

(Updated April 7, 2014, 8:36 p.m.)


Review request for accumulo and Christopher Tubbs.


Changes
-------

Changed package name to address sealed jar conflict.


Bugs: ACCUMULO-1879
    https://issues.apache.org/jira/browse/ACCUMULO-1879


Repository: accumulo


Description
-------

Move shell into a separate module.


Diffs (updated)
-----

  core/pom.xml a89846c239e863b01eaebecde59ab3682969e7e7 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java a8061f77328f9f09d30bc68c7d90bed23c0d3e77

  core/src/main/java/org/apache/accumulo/core/util/format/DeleterFormatter.java 7ac0510ff92cc9d246cc8d40233a08a2dadcfe04

  core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java f481395a5089476bce710ca64ceca5fb4e7a9580

  core/src/main/java/org/apache/accumulo/core/util/shell/ShellCommandException.java 6bef3799742a59a77e0bdce59736d2f13e61334c

  core/src/main/java/org/apache/accumulo/core/util/shell/ShellCompletor.java c64e0c79f9c426b7872127e7de223ac56ad4a8c9

  core/src/main/java/org/apache/accumulo/core/util/shell/ShellExtension.java 5deccefeb12b239c707b88ed874b806d442c0ffb

  core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptions.java 4e573ed72fc8ae457113153cab41ce1e2e597923

  core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptionsJC.java 38692a039deea561bb8933adc22f63051e32c93e

  core/src/main/java/org/apache/accumulo/core/util/shell/ShellUtil.java f0dd505fb3341c0cf405bffc0fd3629a4fc6b26c

  core/src/main/java/org/apache/accumulo/core/util/shell/Token.java b6c5869e7481ab969e421fe27089237c889d1dbc

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/AboutCommand.java a0a73e4284343f4b53e0ff92cc4b001a43a46d1f

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ActiveCompactionIterator.java
bd7d9b2312d4e96dd569e92df07c21b9a381b288 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ActiveScanIterator.java
f1e736f871fbfa70984e70cec77ba4aaac5508b6 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/AddAuthsCommand.java bd478dec938c5bbeaf2a86a075f423569354d1b9

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/AddSplitsCommand.java b8ba621cf9563a7f9341133cf198602473d3c93b

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/AuthenticateCommand.java
8ebdae8fd8aeee81c49b3acba5bc63bc6148a076 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ByeCommand.java f0c9d24a3173f35e3c0792e6a76a0170e45bcb80

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ClasspathCommand.java b2fe300e7e7a89f74172509207764f3fc57c8513

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ClearCommand.java 4f156506840eb9b486400ef46f270bc2b0349143

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/CloneTableCommand.java 207e530000a9134ad3b8bcf8fed3023160e06400

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ClsCommand.java cef60983b816bc75a438f3639097ce46912b5c78

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/CompactCommand.java 55e939535a8ba431133d25956e563b1fa7613615

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ConfigCommand.java c76a51fbca314a3fe0c8d3b0145eb54cd3a22030

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ConstraintCommand.java 208ac4a195d8d6de63eb149b0e3638f581e9fdcf

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateNamespaceCommand.java
a9f3deb79411f566398762943aa13672e2e594c8 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateTableCommand.java
bc5f1d1acb3257528ebf586131a714a6bca3b35e 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateUserCommand.java aa3d7b99ac51bb299d17629d9121b4701ce3f4d6

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DUCommand.java 660ec6cf462d2b73cd9dde4c48f489a301b7df5c

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DebugCommand.java 206b5901c73cd0380422bb6cb94735cc3c3deff9

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteCommand.java b409ccc0ca271ffa18fc2c8259656507176426d6

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteIterCommand.java c10032540e461f6326a953fd9145304b6e1069d4

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteManyCommand.java 7518bf9242e1f06af7e0924ba6e8db0c0558b814

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteNamespaceCommand.java
01d7fc04b57c033badd1a0bcf9f6e6713945b9d1 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteRowsCommand.java 1414b4d93eadfcfbc885ff568d528c1439d3fe4d

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteScanIterCommand.java
9b8699bc01830c6a2c22245b55507e59a2cfea28 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteShellIterCommand.java
89060c10c60b788f670a7c225bb051d3ec8bd5b4 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteTableCommand.java
a5aa32a6697f2a3495a1aff331e8205d57d544f2 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DeleteUserCommand.java 4bc563e1927600cb94764e2968c9a85c42ce1f54

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DropTableCommand.java 3120d6b50d699257953624de1a920520b0fe0299

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/DropUserCommand.java 5aa0fb68a72e81b4e9c9d5bfa6d26dacb54edeff

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/EGrepCommand.java d63991af9ed9bd3c984da21cf54eeb9646dd1937

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExecfileCommand.java f4a2632874dfb783e9bd8a48b27c3c63db51a764

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExitCommand.java c78b0201c28fafc7f2f8ee410ee1ce80ee23fb28

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java
5fd5abb6de72550fc5766a06de35e1b84f2614d4 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExtensionCommand.java ab29d1949bff41fe157464313168682633fa4314

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/FateCommand.java 0196baf60647293fcee9417cfef11f206df3ce62

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/FlushCommand.java de175ebb37972c3c1ed3878dbe846f0597a541a1

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/FormatterCommand.java 631c6e69718855529b950a62ef66f32276325b57

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetAuthsCommand.java e40a83f337b4eecd04a4b95d3b3afc140cf92cff

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetGroupsCommand.java bef2e5cc8ce243e2f7bb3455cd621b794882297b

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/GetSplitsCommand.java 92c7c5db1152061b5638a614c1c20d088fc6763f

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/GrantCommand.java de719fd67f8a4c27d8ffaef75a50a606ec22f908

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/GrepCommand.java c2ff23253b262de30e8778b4535d52902c5e2945

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/HelpCommand.java 9881e00dbc36077ea1a35803169eaddc2ff33deb

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java c1615ead68e3f1f2929ad5dae2008242c823e00f

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/HistoryCommand.java 9531d903aca834ab3b70650824023061e7e788d9

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportDirectoryCommand.java
13db3a4a7f00a1d5f38836baadbb86bfdbff1da3 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java
571c45b7d35f3fa233eb5495b367a18c78769b7e 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/InfoCommand.java 57de6b160a3f1c210692696ceb431e2b6e61a5f7

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/InsertCommand.java a97db050396fce16c27f8b39c66e3c62f647341c

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/InterpreterCommand.java
090bd7f663ccf4382218c17caadcfa48b17917dc 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListCompactionsCommand.java
baa59a0b629049126416234af8fadf76a9a48647 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListIterCommand.java 9aac389854829006e990819db07c455780cea70c

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListScansCommand.java e4a2692eaf91569fa427330a9739fa1d6213b0a8

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ListShellIterCommand.java
7f6ad844daa62a7e8cc288a58c5022260ff4c809 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/MaxRowCommand.java ddb6cc1449a9c5d8f4834e8c89313a8595b81a16

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/MergeCommand.java 9774e36d5e2feaeaa8a9388b0f3e145b7f8b3f65

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/NamespacePermissionsCommand.java
2dcba55176e2b71d9921eb645e64fa4dccacc2f7 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/NamespacesCommand.java 16ee645fd751f391c7f2c1e89aaa5f22b6a47c9a

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/NoTableCommand.java afdab53296440392c1e1e58c8268656894365e6f

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/OfflineCommand.java fde4514c9723ae763b80130174a88e7edea01fe3

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/OnlineCommand.java 7b6ebe2bbaf7701531f8f262e841bc93462c223c

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/OptUtil.java 9915bdf5736b2f9a3e791f478e2b834b16c80c0b

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/PasswdCommand.java 86446a256bcfb0dc83ad20c502d779388d642fca

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/PingCommand.java d0eb6153aa2304c12bf0334008e84423253cc8ef

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/PingIterator.java 2a1020e92fd0696b39b743898527e39c5d51be46

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/QuestionCommand.java b12c2cbff3194c1c84512b1d32383495adde0e26

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/QuitCommand.java 8aa95f57746d33c87f27555c51cf3007cab32d60

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/QuotedStringTokenizer.java
76ebb8f18e7e01e19853bc7acac152aad9a71c5c 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/RenameNamespaceCommand.java
d7ff7c39f22ce08610d713972588b80b44b861b5 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/RenameTableCommand.java
38d8158ad4a9a8dfdd192268c72ce5ef3fd2436e 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/RevokeCommand.java dac864d3ee8544106a280a4edd93c17c186019ba

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ScanCommand.java f3a066387eccf3f9aa6b5ae3582e32d4c660e631

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ScriptCommand.java 5a0eee08081eb84eb3cf95b57dd5b15d238e32a6

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetAuthsCommand.java 256720c8f960f590d148801eb3f3f7f76afa90df

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetGroupsCommand.java 157dbd269536901f1d5b5f1e000517382d0bb680

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java 3d8a5a799fe87d0a574872c920ca912b260e4869

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetScanIterCommand.java
513975c972041d813aa00a1ca2dcbbcceaca64cd 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetShellIterCommand.java
b95725a802c890623754dbf4f4ef25de4df2149f 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/ShellPluginConfigurationCommand.java
d4c9739b0bdd7b3c672c6d3a42dda284ee4665f4 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SleepCommand.java ab6945690efe713921a46d38a95d9ca62e64c618

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/SystemPermissionsCommand.java
3dec6fcbfef4cbb1e24fb79d81afed84d222c609 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/TableCommand.java d77f6fbcbf499433a610ba74091d1f6969a24f4d

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/TableOperation.java 27946b89e7e4029b680eccaf4a17260b7766b762

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/TablePermissionsCommand.java
1f92f21ce5503c28a800e3dce716a2891d3808d3 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/TablesCommand.java a03a986a90363ae7d728e531309674a5c6cf0a1e

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/TraceCommand.java 281a33ac6722320f44d42ccb141445205dc0abd4

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/UserCommand.java 07da4509deaae8f86aaddde8765603e1153fc596

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/UserPermissionsCommand.java
a126159875d51d054a3a763ef41dbab7a4a8f441 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/UsersCommand.java 023c38b0226cfc5cb9a2bc0d3a841bba9be1e09c

  core/src/main/java/org/apache/accumulo/core/util/shell/commands/WhoAmICommand.java e7bb29d794b75a29558bcb1b299b8180e61cccbe

  core/src/test/java/org/apache/accumulo/core/util/format/DeleterFormatterTest.java 9223166f34a5e213e35f705c35e644e073893f9f

  core/src/test/java/org/apache/accumulo/core/util/shell/PasswordConverterTest.java d1d24a62e3471a5455fcd539e0c24cccf4109858

  core/src/test/java/org/apache/accumulo/core/util/shell/ShellConfigTest.java 43d2e12b7d180b9694bf1741de186f438f613bd7

  core/src/test/java/org/apache/accumulo/core/util/shell/ShellSetInstanceTest.java d4c0aea0b2e3093cdd814da3cb11cdd28adf438b

  core/src/test/java/org/apache/accumulo/core/util/shell/ShellTest.java 3d9b89ea19c2ac47261ab02f705d51d4ac2881e4

  core/src/test/java/org/apache/accumulo/core/util/shell/ShellUtilTest.java a5fd179c52aa5554f28b0042bed3e2d3d233d236

  core/src/test/java/org/apache/accumulo/core/util/shell/command/FormatterCommandTest.java
091ef756e924f98ac417a70746b05d764fa68985 
  core/src/test/resources/shelltest.txt  
  examples/simple/pom.xml 752d952978903f890ac41a0aefcbcdf77560e2fe 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/shell/DebugCommand.java
cab78bde5becb6a423842d87ef7558c33940dc05 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/shell/MyAppShellExtension.java
3a22f7b9badf2d283f5c9b2bbbd599b543d8ed10 
  pom.xml a829ba37e75c9d0ad7d3ec620ca92268dfee00ff 
  server/monitor/pom.xml 10586f12d21f6ac573cc3930e0de62abd8417e46 
  server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/ShellServlet.java 182484042bb88c274e15f5d7ce9d7d555a9e2f6d

  shell/pom.xml PRE-CREATION 
  shell/src/test/resources/log4j.properties PRE-CREATION 
  start/src/main/java/org/apache/accumulo/start/Main.java 3c7da95afb91837c85ea35a0688d353dc8625f17

  test/src/test/java/org/apache/accumulo/test/ShellServerIT.java b3d44e34860e732918c8a440d908036d4fd68469


Diff: https://reviews.apache.org/r/20087/diff/


Testing
-------


Thanks,

Mike Drob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message