Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08129CCE3 for ; Fri, 14 Mar 2014 18:15:16 +0000 (UTC) Received: (qmail 34979 invoked by uid 500); 14 Mar 2014 18:14:57 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 34615 invoked by uid 500); 14 Mar 2014 18:14:48 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 34363 invoked by uid 99); 14 Mar 2014 18:14:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Mar 2014 18:14:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6F7DE1D50DE; Fri, 14 Mar 2014 18:14:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0460271406312950578==" MIME-Version: 1.0 Subject: Re: Review Request 19226: ACCUMULO-2477 Replace our implemenations of Entry From: keith@deenlo.com To: "Mike Drob" , "accumulo" , keith@deenlo.com, "Bill Havanki" Date: Fri, 14 Mar 2014 18:14:43 -0000 Message-ID: <20140314181443.30484.40481@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/19226/ X-Sender: noreply@reviews.apache.org References: <20140314172927.30484.46871@reviews.apache.org> In-Reply-To: <20140314172927.30484.46871@reviews.apache.org> Reply-To: keith@deenlo.com X-ReviewRequest-Repository: accumulo --===============0460271406312950578== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On March 14, 2014, 5:29 p.m., kturner wrote: > > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java, line 63 > > > > > > why not use immutable entry here? > > Bill Havanki wrote: > My guess is because the old entry implementation does not throw UnsupportedOperationException on setValue calls. yeah, I saw the old implementation does not throw. The old implementation looks kinda broken though, I suspect it should throw an exception. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19226/#review37224 ----------------------------------------------------------- On March 14, 2014, 5:10 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19226/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 5:10 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2477 > https://issues.apache.org/jira/browse/ACCUMULO-2477 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2477 Replace our implemenations of Entry > > Most of our uses of Map.Entry can defer to SimpleImmutableEntry. We > should use that instead of maintaining our own version. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java 30e12c1a42327d79dddf183992a1dc397607d407 > core/src/main/java/org/apache/accumulo/core/data/Key.java 74975aebb3cf1184f984d1325ccb9a02e23a6915 > core/src/main/java/org/apache/accumulo/core/data/KeyValue.java 83996f86eb99cfa72867053a90f4370c1d41e4d7 > core/src/main/java/org/apache/accumulo/core/util/Pair.java fb4ad80067cf5ea3a219a6b5876b6ed2f71fa8f3 > examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java 3a211e2b55052292a7e28ed585c9848a81995a33 > server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java a454d6c1f3233120fa7af217afe5230542fed0c1 > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java dd20fd911e8e4bb047a35aec2bc94e5948e8075a > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java cdb9dbf015be231358af420a79231082a9566ac0 > > Diff: https://reviews.apache.org/r/19226/diff/ > > > Testing > ------- > > Existing unit tests still pass. > > > Thanks, > > Mike Drob > > --===============0460271406312950578==--