Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A55F51060D for ; Thu, 13 Mar 2014 16:57:02 +0000 (UTC) Received: (qmail 54113 invoked by uid 500); 13 Mar 2014 16:57:02 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 53865 invoked by uid 500); 13 Mar 2014 16:57:01 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 53834 invoked by uid 99); 13 Mar 2014 16:56:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Mar 2014 16:56:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9E7A01D4BC6; Thu, 13 Mar 2014 16:56:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5901428112760040009==" MIME-Version: 1.0 Subject: Re: Review Request 19189: ACCUMULO-2465 Unit tests for BigDecimalCombiner From: keith@deenlo.com To: "Mike Drob" , "accumulo" , keith@deenlo.com Date: Thu, 13 Mar 2014 16:56:57 -0000 Message-ID: <20140313165657.32376.1884@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/19189/ X-Sender: noreply@reviews.apache.org References: <20140313135332.32376.88179@reviews.apache.org> In-Reply-To: <20140313135332.32376.88179@reviews.apache.org> Reply-To: keith@deenlo.com X-ReviewRequest-Repository: accumulo --===============5901428112760040009== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19189/#review37065 ----------------------------------------------------------- core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java would be nice to include keys that should not be aggregated. Like a key w/ a different row or col core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java I don't thinkk it matters but the integer is irking me. would prefer -14.0. Feel free to ignore this comment. core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java use max combiner for the name - kturner On March 13, 2014, 1:53 p.m., Mike Drob wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19189/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:53 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2465 > https://issues.apache.org/jira/browse/ACCUMULO-2465 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2465 Unit tests for BigDecimalCombiner > > Add tests for min and max. Refactor setup into @Before method. > > > Diffs > ----- > > core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java 4cf4d5d65ab8a2705293e547e76b196a7fd7a5a6 > core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java 0c91ef7c266f13a4dc67045de0d7a2a774e985c4 > > Diff: https://reviews.apache.org/r/19189/diff/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Mike Drob > > --===============5901428112760040009==--