Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEC46CC38 for ; Wed, 12 Mar 2014 18:57:15 +0000 (UTC) Received: (qmail 1644 invoked by uid 500); 12 Mar 2014 18:57:15 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 1496 invoked by uid 500); 12 Mar 2014 18:57:14 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 1072 invoked by uid 99); 12 Mar 2014 18:57:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Mar 2014 18:57:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D08A41D50DE; Wed, 12 Mar 2014 18:57:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4019445855975566495==" MIME-Version: 1.0 Subject: Review Request 19142: Deprecate instance.dfs.dir and instance.dfs.uri From: "Josh Elser" To: "Eric Newton" , keith@deenlo.com Cc: "accumulo" , "Josh Elser" Date: Wed, 12 Mar 2014 18:57:10 -0000 Message-ID: <20140312185710.22644.24809@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/19142/ X-Sender: "Josh Elser" Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============4019445855975566495== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19142/ ----------------------------------------------------------- Review request for accumulo, Eric Newton and kturner. Bugs: ACCUMULO-2061 https://issues.apache.org/jira/browse/ACCUMULO-2061 Repository: accumulo Description ------- Removes instance.dfs.dir from being appended to the configured instance.volumes values. Removed FileSystem from the VolumeManager in favor of a new Volume class. The Volume class contains a FileSystem but also a base path which is denotes what the Accumulo directory is on that FileSystem. Diffs ----- core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 0b2f10e core/src/main/java/org/apache/accumulo/core/client/impl/OfflineScanner.java c90d380 core/src/main/java/org/apache/accumulo/core/conf/Property.java fc4d012 core/src/main/java/org/apache/accumulo/core/file/VolumeConfiguration.java fb8c6c8 core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 4cfefad core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/PrintInfo.java f21190e core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 0c2cf3c core/src/main/java/org/apache/accumulo/core/volume/Volume.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/volume/VolumeConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/volume/VolumeImpl.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/zookeeper/ZooUtil.java de1b432 server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 2fa9051 server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 8983d08 server/base/src/main/java/org/apache/accumulo/server/client/BulkImporter.java dc9acf8 server/base/src/main/java/org/apache/accumulo/server/client/HdfsZooInstance.java 6993a0a server/base/src/main/java/org/apache/accumulo/server/conf/ZooConfiguration.java 32f6126 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java f0c7083 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 80301ef server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java da3baa6 server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 925f602 server/base/src/main/java/org/apache/accumulo/server/master/recovery/HadoopLogCloser.java 7edc0cf server/base/src/main/java/org/apache/accumulo/server/master/recovery/MapRLogCloser.java bba7ac5 server/base/src/main/java/org/apache/accumulo/server/util/ChangeSecret.java ac13034 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 8e38cbd server/base/src/main/java/org/apache/accumulo/server/util/LocalityCheck.java a96e791 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b237cd0 server/base/src/main/java/org/apache/accumulo/server/util/ZooKeeperMain.java 37edb1a server/base/src/test/java/org/apache/accumulo/server/ServerConstantsTest.java a316155 server/base/src/test/java/org/apache/accumulo/server/fs/FileTypeTest.java 205a793 server/base/src/test/java/org/apache/accumulo/server/fs/VolumeUtilTest.java c85be45 server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectionTest.java 4e2a878 server/master/src/main/java/org/apache/accumulo/master/tableOps/ExportTable.java 36bbb53 server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 7e84c55 server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/DefaultServlet.java 942f866 server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java e9f1083 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 151db6e server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java bb95532 server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java cc4b68d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 475621b server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/MajorCompactionRequest.java 3bbb476 server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java 8f783c3 server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java a28bac4 server/tserver/src/test/java/org/apache/accumulo/tserver/RootFilesTest.java 1cd8f12 server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java 50c8b31 server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java c4d3dfb server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java 359bfa1 server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java af149fa test/src/main/java/org/apache/accumulo/test/performance/scan/CollectTabletStats.java 9a9cad7 test/src/test/java/org/apache/accumulo/test/VolumeIT.java a0efe45 test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java c8023c0 Diff: https://reviews.apache.org/r/19142/diff/ Testing ------- All unit and integration tests run. Tested locally with multiple volumes on a single HDFS. Tested upgrade from 1.5 with volumes (verified that relative paths were rewritten as data was ingested). Tested volume replacement on a new instance. All "real instance" tests used CI to generate data. Thanks, Josh Elser --===============4019445855975566495==--