Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A03E106E8 for ; Fri, 7 Mar 2014 19:48:58 +0000 (UTC) Received: (qmail 2793 invoked by uid 500); 7 Mar 2014 19:48:55 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 2749 invoked by uid 500); 7 Mar 2014 19:48:54 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 2708 invoked by uid 99); 7 Mar 2014 19:48:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2014 19:48:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 13C371D4C69; Fri, 7 Mar 2014 19:48:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1330029345194134810==" MIME-Version: 1.0 Subject: Re: Review Request 18917: Add a NOT (!) operator to ColumnVisibility (ACCUMULO-2439) From: "Mike Drob" To: "Mike Drob" , "Joe Ferner" , "accumulo" Date: Fri, 07 Mar 2014 19:48:41 -0000 Message-ID: <20140307194841.30871.13891@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mike Drob" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/18917/ X-Sender: "Mike Drob" References: <20140307194153.2625.54866@reviews.apache.org> In-Reply-To: <20140307194153.2625.54866@reviews.apache.org> Reply-To: "Mike Drob" X-ReviewRequest-Repository: accumulo --===============1330029345194134810== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18917/#review36568 ----------------------------------------------------------- core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java Add JavaDoc to inform user's that this will apply DeMorgan's. core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java This would likely be better as a switch/case. core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java Can you add a double DeMorgan's test? i.e. start with "(!a|!b)&(!c|!d)" and normalize from there. - Mike Drob On March 7, 2014, 7:41 p.m., Joe Ferner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18917/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 7:41 p.m.) > > > Review request for accumulo. > > > Repository: accumulo > > > Description > ------- > > This patch adds a NOT "!" operator to ColumnVisibility. > > The syntax is as follows: > !a > (!a)&(!b) > a&(!b) > a&(!(b|c)) > > Because of the nature of the current visibility parsing algorithm the additional parentheses are required. > In the shell, the "Unable to render embedded object: File (" requires escaping. This is due to how JLine parses the command and attempts to substitute ") not found." with history. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java 75091d2 > core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 725b2c7 > core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 7a6a80d > core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java ee4d2ee > > Diff: https://reviews.apache.org/r/18917/diff/ > > > Testing > ------- > > This patch includes unit tests for parsing, flattening, and evaluating the not operator. > > > Thanks, > > Joe Ferner > > --===============1330029345194134810==--