accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Date Wed, 26 Mar 2014 18:33:18 GMT


> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 34
> > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line34>
> >
> >     The store field can be final.

fixed.


> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 37
> > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line37>
> >
> >     You could check for null here (with Guava's Preconditions, for instance).

fixed


> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java, line 31
> > <https://reviews.apache.org/r/19662/diff/2/?file=536761#file536761line31>
> >
> >     All members of this interface, including the enum, are automatically public,
so the "public" modifier should be dropped.

also removed public from methods in modified interfaces.


> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java, lines 46-49
> > <https://reviews.apache.org/r/19662/diff/2/?file=536761#file536761line46>
> >
> >     Missing @return. (Yeah, missing from the original too.) If it's possible to
complete the Javadoc across this class, that would be a welcome addition.

fixed


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38605
-----------------------------------------------------------


On March 26, 2014, 1:06 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 1:06 a.m.)
> 
> 
> Review request for accumulo and kturner.
> 
> 
> Bugs: ACCUMULO-2551
>     https://issues.apache.org/jira/browse/ACCUMULO-2551
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Per request in #Accumulo, proposed changes to provide read only access
> 
> 
> Diffs
> -----
> 
>   fate/pom.xml 433e61a 
>   fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466 
>   fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b 
>   fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION 
>   fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION 
>   fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION 
>   fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10 
>   fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064 
>   fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649 
>   fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION 
>   fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131 
>   server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc 
>   server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864 
> 
> Diff: https://reviews.apache.org/r/19662/diff/
> 
> 
> Testing
> -------
> 
> existing and new unit tests run
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message