accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 19428: ACCUMULO-2503 add formatter tests
Date Mon, 24 Mar 2014 16:01:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19428/
-----------------------------------------------------------

(Updated March 24, 2014, 4:01 p.m.)


Review request for accumulo.


Changes
-------

Incorporated Bill H.'s suggestions. Switched empty values to use the new no-arg constructor.


Bugs: ACCUMULO-2503
    https://issues.apache.org/jira/browse/ACCUMULO-2503


Repository: accumulo


Description
-------

ACCUMULO-2503 add formatter tests


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/util/format/AggregatingFormatter.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/util/format/BinaryFormatter.java 5021d66fc9117ff97203f6a46ec7422b9db3a598

  core/src/main/java/org/apache/accumulo/core/util/format/DefaultFormatter.java ee4a2200a433d2e5a0268066421426af4594d346

  core/src/main/java/org/apache/accumulo/core/util/format/DeleterFormatter.java 8547f12e4c7f7d2435cf890be37f5fd9279dcb63

  core/src/main/java/org/apache/accumulo/core/util/format/FormatterFactory.java 5451843b114ff8d605511ce7dd21850c4048e893

  core/src/main/java/org/apache/accumulo/core/util/format/HexFormatter.java 1def7127a58c73313618c739bdd7f50bb8bc772f

  core/src/main/java/org/apache/accumulo/core/util/format/ShardedTableDistributionFormatter.java
577167a150b8861de714fdde79d2ba41ed06fb89 
  core/src/main/java/org/apache/accumulo/core/util/format/StatisticsDisplayFormatter.java
dd9de6ce6b967210322bec6c9b704f46b6031917 
  core/src/test/java/org/apache/accumulo/core/util/format/DateStringFormatterTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/util/format/DefaultFormatterTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/util/format/DeleterFormatterTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/util/format/FormatterFactoryTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/util/format/HexFormatterTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/util/format/ShardedTableDistributionFormatterTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/util/format/StatisticsDisplayFormatterTest.java
PRE-CREATION 
  core/src/test/resources/log4j.properties dfc93bf2f1bf04de85e5dd8fca1b966dc803e067 

Diff: https://reviews.apache.org/r/19428/diff/


Testing
-------

New and old unit tests pass.


Thanks,

Mike Drob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message