accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 19496: ACCUMULO-2487 match Value implementation to javadocs. check for null args.
Date Fri, 21 Mar 2014 19:51:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19496/#review38177
-----------------------------------------------------------

Ship it!


Ship It!

- kturner


On March 20, 2014, 9:32 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19496/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 9:32 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2487
>     https://issues.apache.org/jira/browse/ACCUMULO-2487
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Updates Value() to create an empty backing array. Makes methods that touch the backing
array reject nulls proactively. Changed some internal checks to asserts since there ought
not be a way to make the backing array null.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/data/Value.java 39ebbd0 
>   core/src/test/java/org/apache/accumulo/core/data/ValueTest.java 9b68222 
> 
> Diff: https://reviews.apache.org/r/19496/diff/
> 
> 
> Testing
> -------
> 
> existing and new unit tests pass, with the exception of changing some for the default
constructor since they matched the previous implementation rather than the javadoc.
> 
> mvn verify in progress.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message