accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 19368: ACCUMULO-2494 Delegate math to commons-math
Date Tue, 18 Mar 2014 21:26:15 GMT


> On March 18, 2014, 7:39 p.m., Sean Busbey wrote:
> > which branch is this against?
> 
> Mike Drob wrote:
>     Probably should be against 1.5.1, but I'm not sure.
> 
> Sean Busbey wrote:
>     I'd like to see this against all active dev branches, starting with 1.4.5-SNAP. I
can file a follow on backport ticket if you like.
> 
> kturner wrote:
>     in 1.6.0-SNAPSHOT, the function to get the std dev seems to only be used in test
code.   If this is the case in earlier relases, then thats not a very strong case for applying
it.

Please, let's avoid backports for new changes that come in. Put in the correct place the first
time.


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19368/#review37610
-----------------------------------------------------------


On March 18, 2014, 8:40 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19368/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 8:40 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2494
>     https://issues.apache.org/jira/browse/ACCUMULO-2494
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2494 Delegate math to commons-math
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/util/Stat.java e65265c6decde47ef229377653112a677fef8112

>   core/src/test/java/org/apache/accumulo/core/util/StatTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19368/diff/
> 
> 
> Testing
> -------
> 
> Unit tests results compared with calculations from Wolfram Alpha.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message