accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 19192: ACCUMULO-2468 Add unit tests for o.a.a.core.data
Date Thu, 13 Mar 2014 19:36:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19192/
-----------------------------------------------------------

(Updated March 13, 2014, 7:36 p.m.)


Review request for accumulo.


Changes
-------

Incorporated Bill H's suggestions.


Bugs: ACCUMULO-2468
    https://issues.apache.org/jira/browse/ACCUMULO-2468


Repository: accumulo


Description (updated)
-------

ACCUMULO-2468 Add unit tests for o.a.a.core.data

Add unit tests for several classes. Convert from JUnit 3 to 4 where
appropriate. Fix bugs where new unit tests uncovered them. Replaced
assertTrue with assertEquals where possible.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java ff56c316be9100657af3f8be82d829cde6c582eb

  core/src/main/java/org/apache/accumulo/core/data/KeyExtent.java dda78fb58f31bfb5bdd101558d6a60961f017194

  core/src/test/java/org/apache/accumulo/core/data/ArrayByteSequenceTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/data/ByteSequenceTest.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/data/ColumnTest.java f04094239e18377a4e65029c746764e811a8078a

  core/src/test/java/org/apache/accumulo/core/data/KeyExtentTest.java 068ec89ad6b8c9df99f1b584197fbac1e0514256

  core/src/test/java/org/apache/accumulo/core/data/KeyTest.java 56442a18ac9f6c9132c81170ec3b8c9ba6633cb4


Diff: https://reviews.apache.org/r/19192/diff/


Testing
-------

Unit tests.


Thanks,

Mike Drob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message