accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 19192: ACCUMULO-2468 Add unit tests for o.a.a.core.data
Date Thu, 13 Mar 2014 19:34:35 GMT


> On March 13, 2014, 6:52 p.m., Bill Havanki wrote:
> > Overall I'd like to see more test coverage, especially in ByteSequence and ArrayByteSequence.
Nevertheless, these are welcome additions.

ByteSequence in particular is hard to test since it is an abstract class and ArrayBS is our
only implementation. I've added some tests for failure cases, though.


> On March 13, 2014, 6:52 p.m., Bill Havanki wrote:
> > core/src/test/java/org/apache/accumulo/core/data/ColumnTest.java, lines 38-43
> > <https://reviews.apache.org/r/19192/diff/1/?file=518743#file518743line38>
> >
> >     This test is a good candidate for using JUnit theories, if you're interested
in learning about them.

Maybe. The test methods make assertions about the relationship between various columns, though,
and not generalized assertions about columns as a data type. Really, I would love to use something
like scalacheck, but we do not live in such a world.


> On March 13, 2014, 6:52 p.m., Bill Havanki wrote:
> > core/src/test/java/org/apache/accumulo/core/data/ColumnTest.java, line 36
> > <https://reviews.apache.org/r/19192/diff/1/?file=518743#file518743line36>
> >
> >     You could use @BeforeClass here and make this and the col array both static.

For performance reasons? Sure.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19192/#review37086
-----------------------------------------------------------


On March 13, 2014, 6:02 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19192/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 6:02 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2468
>     https://issues.apache.org/jira/browse/ACCUMULO-2468
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2468 Add unit tests for o.a.a.core.data
> 
>     Add unit tests for several classes. Convert from JUnit 3 to 4 where
>     appropriate. Fix bugs where new unit tests uncovered them.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java ff56c316be9100657af3f8be82d829cde6c582eb

>   core/src/main/java/org/apache/accumulo/core/data/KeyExtent.java dda78fb58f31bfb5bdd101558d6a60961f017194

>   core/src/test/java/org/apache/accumulo/core/data/ArrayByteSequenceTest.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/data/ByteSequenceTest.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/data/ColumnTest.java f04094239e18377a4e65029c746764e811a8078a

>   core/src/test/java/org/apache/accumulo/core/data/KeyExtentTest.java 068ec89ad6b8c9df99f1b584197fbac1e0514256

>   core/src/test/java/org/apache/accumulo/core/data/KeyTest.java 56442a18ac9f6c9132c81170ec3b8c9ba6633cb4

> 
> Diff: https://reviews.apache.org/r/19192/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message