accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 19189: ACCUMULO-2465 Unit tests for BigDecimalCombiner
Date Thu, 13 Mar 2014 18:39:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19189/
-----------------------------------------------------------

(Updated March 13, 2014, 6:39 p.m.)


Review request for accumulo.


Changes
-------

Check that the non-aggregating keys didn't get modified in some unexpected way.


Bugs: ACCUMULO-2465
    https://issues.apache.org/jira/browse/ACCUMULO-2465


Repository: accumulo


Description (updated)
-------

ACCUMULO-2465 Unit tests for BigDecimalCombiner

Add tests for min and max. Refactor setup into @Before method.
Add keys that won't combine to make sure all values are still correct.


Diffs (updated)
-----

  core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java 4cf4d5d65ab8a2705293e547e76b196a7fd7a5a6

  core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java 0c91ef7c266f13a4dc67045de0d7a2a774e985c4


Diff: https://reviews.apache.org/r/19189/diff/


Testing
-------

Unit tests.


Thanks,

Mike Drob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message