accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 19189: ACCUMULO-2465 Unit tests for BigDecimalCombiner
Date Thu, 13 Mar 2014 16:56:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19189/#review37065
-----------------------------------------------------------



core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java
<https://reviews.apache.org/r/19189/#comment68325>

    would be nice to include keys that should not be aggregated.  Like a key w/ a different
row or col



core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java
<https://reviews.apache.org/r/19189/#comment68324>

    I don't thinkk it matters but the integer is irking me.  would prefer -14.0.  Feel free
to ignore this comment.



core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java
<https://reviews.apache.org/r/19189/#comment68323>

    use max combiner for the name


- kturner


On March 13, 2014, 1:53 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19189/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 1:53 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2465
>     https://issues.apache.org/jira/browse/ACCUMULO-2465
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2465 Unit tests for BigDecimalCombiner
> 
> Add tests for min and max. Refactor setup into @Before method.
> 
> 
> Diffs
> -----
> 
>   core/src/test/java/org/apache/accumulo/core/iterators/user/BigDecimalCombinerTest.java
4cf4d5d65ab8a2705293e547e76b196a7fd7a5a6 
>   core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java 0c91ef7c266f13a4dc67045de0d7a2a774e985c4

> 
> Diff: https://reviews.apache.org/r/19189/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message