accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Ferner" <>
Subject Re: Review Request 18917: Add a NOT (!) operator to ColumnVisibility (ACCUMULO-2439)
Date Tue, 11 Mar 2014 15:51:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 11, 2014, 3:51 p.m.)

Review request for accumulo.


Add JavaDoc to inform user's that this will apply DeMorgan's.
Changed logic to switch statement.
Added double DeMorgan's test.

Repository: accumulo


This patch adds a NOT "!" operator to ColumnVisibility.

The syntax is as follows:

Because of the nature of the current visibility parsing algorithm the additional parentheses
are required.
In the shell, the "Unable to render embedded object: File (" requires escaping. This is due
to how JLine parses the command and attempts to substitute ") not found." with history.

Diffs (updated)

  core/src/main/java/org/apache/accumulo/core/security/ 75091d2 
  core/src/main/java/org/apache/accumulo/core/security/ 725b2c7 
  core/src/test/java/org/apache/accumulo/core/security/ 7a6a80d 
  core/src/test/java/org/apache/accumulo/core/security/ ee4d2ee



This patch includes unit tests for parsing, flattening, and evaluating the not operator.


Joe Ferner

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message