accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 18969: ACCUMULO-2444 unit tests for a.o.o.core.security
Date Mon, 10 Mar 2014 15:24:14 GMT


> On March 10, 2014, 3:22 p.m., Bill Havanki wrote:
> > core/src/test/java/org/apache/accumulo/core/security/NamespacePermissionsTest.java,
line 37
> > <https://reviews.apache.org/r/18969/diff/1/?file=515114#file515114line37>
> >
> >     Does it make sense to test the reverse, i.e., that each table and system permission
has an equivalent namespace permission?

No, because it's not true.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18969/#review36645
-----------------------------------------------------------


On March 10, 2014, 2:24 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18969/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 2:24 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2444
>     https://issues.apache.org/jira/browse/ACCUMULO-2444
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2444 unit tests for a.o.o.core.security
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java f9f7564eea7e571d70e44ff301bc77c48803f7a7

>   core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java 7a6a80d61b9725a47a8dac79f5a6ad3bd1d304bf

>   core/src/test/java/org/apache/accumulo/core/security/NamespacePermissionsTest.java
PRE-CREATION 
>   core/src/test/java/org/apache/accumulo/core/security/VisibilityConstraintTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18969/diff/
> 
> 
> Testing
> -------
> 
> Old unit tests pass. New unit tests pass.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message