Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============0592780148310635950=="
MIME-Version: 1.0
Subject: Re: Review Request 18444: ACCUMULO-2399 Continuous* wait a bit for
 scanners
From: "Bill Havanki" <bhavanki@clouderagovt.com>
To: "Bill Havanki" <bhavanki@clouderagovt.com>,
 "accumulo" <dev@accumulo.apache.org>, "Mike Drob" <mdrob@mdrob.com>
Date: Tue, 25 Feb 2014 14:01:11 -0000
Message-ID: <20140225140111.30920.45712@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Havanki" <noreply@reviews.apache.org>
References: <20140224233549.21193.61290@reviews.apache.org>
In-Reply-To: <20140224233549.21193.61290@reviews.apache.org>
Reply-To: "Bill Havanki" <bhavanki@clouderagovt.com>

--===============0592780148310635950==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18444/#review35398
-----------------------------------------------------------


src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousUtil.java
<https://reviews.apache.org/r/18444/#comment65889>

    What if, due to the cluster environment, it always takes longer than 3 seconds? Should the interval be configurable?
    
    How about requiring the table to be manually created first? Then this just fails quick with a nice error "make the table and try again".


src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousUtil.java
<https://reviews.apache.org/r/18444/#comment65888>

    You might as well just let the InterruptedException propagate out. An interrupt during the sleep should be interpreted as a signal to cancel the test.


- Bill Havanki


On Feb. 24, 2014, 6:35 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18444/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:35 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2399
>     https://issues.apache.org/jira/browse/ACCUMULO-2399
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2399 Continuous* wait a bit for scanners
> 
> When starting ContinuousIngest concurrently with consumers, many of the
> consumers would die if they came up before the table had been created.
> Make the code a bit more robust during start-up.
> 
> 
> Diffs
> -----
> 
>   src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousBatchWalker.java 4659affc49fc7fc2519e092330dda817ccbbadcd 
>   src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousQuery.java c8ae6ecf9e5ef2bd51cb803cba429baaf57f3d6a 
>   src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousScanner.java 0ac3df63a260a201544b3623d4901b355d7ea21a 
>   src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousUtil.java PRE-CREATION 
>   src/server/src/main/java/org/apache/accumulo/server/test/continuous/ContinuousWalk.java 7d1e7f95c7e5a7a172990322e2992e536f2725e3 
> 
> Diff: https://reviews.apache.org/r/18444/diff/
> 
> 
> Testing
> -------
> 
> Unit tests. Started processes on 3 node cluster and batch walkers did not die.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


--===============0592780148310635950==--