Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA6E5100EB for ; Tue, 4 Feb 2014 16:27:11 +0000 (UTC) Received: (qmail 8742 invoked by uid 500); 4 Feb 2014 16:27:10 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 8717 invoked by uid 500); 4 Feb 2014 16:27:10 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 8702 invoked by uid 99); 4 Feb 2014 16:27:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 16:27:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 48BDB1D4747; Tue, 4 Feb 2014 16:27:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6841848438730964963==" MIME-Version: 1.0 Subject: Re: Review Request 17426: ACCUMULO-1948 Tablet constructor no longer leaking this From: "Bill Havanki" To: "Eric Newton" , "Bill Havanki" , "accumulo" , keith@deenlo.com Date: Tue, 04 Feb 2014 16:27:08 -0000 Message-ID: <20140204162708.3575.42301@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/17426/ X-Sender: "Bill Havanki" References: <20140131192834.21445.67533@reviews.apache.org> In-Reply-To: <20140131192834.21445.67533@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============6841848438730964963== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17426/ ----------------------------------------------------------- (Updated Feb. 4, 2014, 11:27 a.m.) Review request for accumulo. Changes ------- Addressing Keith's issues. Thanks for the thoughtful review, Keith! Bugs: ACCUMULO-1948 https://issues.apache.org/jira/browse/ACCUMULO-1948 Repository: accumulo Description ------- Change in the construction of the cross-referencing between Tablet and TabletResourceManager to avoid the Tablet constructor leaking this. Diffs (updated) ----- server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 5ea2401acc720c70d58ee04c2dd82dc79fcf2b99 server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 9d08c81f9b07a8c5f8a281769fd2914f5c8fc82b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java e95843775c85ecf90a2b4c7afce91094381da450 server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17426/diff/ Testing ------- Added unit test. Tested on pseudo-cluster with shell activity, randomwalk MultiTable test. Thanks, Bill Havanki --===============6841848438730964963==--