accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 18438: ACCUMULO-780
Date Tue, 25 Feb 2014 18:36:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18438/#review35427
-----------------------------------------------------------



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65930>

    hlep? :)



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65915>

    Are these vestigal debugging statements? If so, they should be removed.



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65918>

    Can we use getopt or getopts or some other library, assuming it is portable between GNU/BSD?
Custom argument parsing code always makes me nervous.



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65916>

    nit: whitespace



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65921>

    Since you've already declared that you're using bash, it is generally safer to use [[
instead of [. This occurs in many places throughout the file, but the same comment applies.



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65920>

    nit: whitespace



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65929>

    If you want to get really fancy, you can do:
    
    for var in SIZE TYPE HADOOP_VERSION; do
      if [[ -z ${!var} ]]; then
        echo "Invalid $var configuration"
        echo 1
      fi
    done
    
    Your way is probably more readable, though.



bin/bootstrap_config.sh
<https://reviews.apache.org/r/18438/#comment65933>

    Hadoop 2 is the default in Accumulo 1.6+, so Hadoop 1 should be the special case instead.


- Mike Drob


On Feb. 25, 2014, 6:07 p.m., John McNamee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18438/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 6:07 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Initial patch
> 
> 
> Diffs
> -----
> 
>   assemble/pom.xml 5a1d8e3 
>   assemble/src/main/assemblies/component.xml fa53d5e 
>   bin/bootstrap_config.sh be472d3 
>   conf/accumulo.policy.example 2964f06 
>   conf/examples/1GB/native-standalone/accumulo-env.sh 9e9b6a6 
>   conf/examples/1GB/native-standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/1GB/native-standalone/accumulo-site.xml b68059c 
>   conf/examples/1GB/native-standalone/auditLog.xml 9b7987e 
>   conf/examples/1GB/native-standalone/gc 63fb8bb 
>   conf/examples/1GB/native-standalone/generic_logger.xml 4d2af90 
>   conf/examples/1GB/native-standalone/log4j.properties a4bcb2e 
>   conf/examples/1GB/native-standalone/masters 63fb8bb 
>   conf/examples/1GB/native-standalone/monitor 63fb8bb 
>   conf/examples/1GB/native-standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/1GB/native-standalone/slaves 63fb8bb 
>   conf/examples/1GB/native-standalone/tracers 63fb8bb 
>   conf/examples/1GB/standalone/accumulo-env.sh 8b904ac 
>   conf/examples/1GB/standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/1GB/standalone/accumulo-site.xml 1bca857 
>   conf/examples/1GB/standalone/auditLog.xml 9b7987e 
>   conf/examples/1GB/standalone/gc 63fb8bb 
>   conf/examples/1GB/standalone/generic_logger.xml 4d2af90 
>   conf/examples/1GB/standalone/log4j.properties a4bcb2e 
>   conf/examples/1GB/standalone/masters 63fb8bb 
>   conf/examples/1GB/standalone/monitor 63fb8bb 
>   conf/examples/1GB/standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/1GB/standalone/slaves 63fb8bb 
>   conf/examples/1GB/standalone/tracers 63fb8bb 
>   conf/examples/2GB/native-standalone/accumulo-env.sh 5f6d2cb 
>   conf/examples/2GB/native-standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/2GB/native-standalone/accumulo-site.xml 9eaa5ff 
>   conf/examples/2GB/native-standalone/auditLog.xml 9b7987e 
>   conf/examples/2GB/native-standalone/gc 63fb8bb 
>   conf/examples/2GB/native-standalone/generic_logger.xml 4d2af90 
>   conf/examples/2GB/native-standalone/log4j.properties a4bcb2e 
>   conf/examples/2GB/native-standalone/masters 63fb8bb 
>   conf/examples/2GB/native-standalone/monitor 63fb8bb 
>   conf/examples/2GB/native-standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/2GB/native-standalone/slaves 63fb8bb 
>   conf/examples/2GB/native-standalone/tracers 63fb8bb 
>   conf/examples/2GB/standalone/accumulo-env.sh feba48c 
>   conf/examples/2GB/standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/2GB/standalone/accumulo-site.xml c9e0309 
>   conf/examples/2GB/standalone/auditLog.xml 9b7987e 
>   conf/examples/2GB/standalone/gc 63fb8bb 
>   conf/examples/2GB/standalone/generic_logger.xml 4d2af90 
>   conf/examples/2GB/standalone/log4j.properties a4bcb2e 
>   conf/examples/2GB/standalone/masters 63fb8bb 
>   conf/examples/2GB/standalone/monitor 63fb8bb 
>   conf/examples/2GB/standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/2GB/standalone/slaves 63fb8bb 
>   conf/examples/2GB/standalone/tracers 63fb8bb 
>   conf/examples/3GB/native-standalone/accumulo-env.sh be72992 
>   conf/examples/3GB/native-standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/3GB/native-standalone/accumulo-site.xml 9b82ed3 
>   conf/examples/3GB/native-standalone/auditLog.xml 9b7987e 
>   conf/examples/3GB/native-standalone/gc 63fb8bb 
>   conf/examples/3GB/native-standalone/generic_logger.xml 4d2af90 
>   conf/examples/3GB/native-standalone/log4j.properties a4bcb2e 
>   conf/examples/3GB/native-standalone/masters 63fb8bb 
>   conf/examples/3GB/native-standalone/monitor 63fb8bb 
>   conf/examples/3GB/native-standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/3GB/native-standalone/slaves 63fb8bb 
>   conf/examples/3GB/native-standalone/tracers 63fb8bb 
>   conf/examples/3GB/standalone/accumulo-env.sh 6e5fb3a 
>   conf/examples/3GB/standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/3GB/standalone/accumulo-site.xml a127cbd 
>   conf/examples/3GB/standalone/auditLog.xml 9b7987e 
>   conf/examples/3GB/standalone/gc 63fb8bb 
>   conf/examples/3GB/standalone/generic_logger.xml 4d2af90 
>   conf/examples/3GB/standalone/log4j.properties a4bcb2e 
>   conf/examples/3GB/standalone/masters 63fb8bb 
>   conf/examples/3GB/standalone/monitor 63fb8bb 
>   conf/examples/3GB/standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/3GB/standalone/slaves 63fb8bb 
>   conf/examples/3GB/standalone/tracers 63fb8bb 
>   conf/examples/512MB/native-standalone/accumulo-env.sh e02b524 
>   conf/examples/512MB/native-standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/512MB/native-standalone/accumulo-site.xml 0e8bdb2 
>   conf/examples/512MB/native-standalone/auditLog.xml 9b7987e 
>   conf/examples/512MB/native-standalone/gc 63fb8bb 
>   conf/examples/512MB/native-standalone/generic_logger.xml 4d2af90 
>   conf/examples/512MB/native-standalone/log4j.properties a4bcb2e 
>   conf/examples/512MB/native-standalone/masters 63fb8bb 
>   conf/examples/512MB/native-standalone/monitor 63fb8bb 
>   conf/examples/512MB/native-standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/512MB/native-standalone/slaves 63fb8bb 
>   conf/examples/512MB/native-standalone/tracers 63fb8bb 
>   conf/examples/512MB/standalone/accumulo-env.sh 457e1d3 
>   conf/examples/512MB/standalone/accumulo-metrics.xml 60f9f8d 
>   conf/examples/512MB/standalone/accumulo-site.xml 1a30ce7 
>   conf/examples/512MB/standalone/auditLog.xml 9b7987e 
>   conf/examples/512MB/standalone/gc 63fb8bb 
>   conf/examples/512MB/standalone/generic_logger.xml 4d2af90 
>   conf/examples/512MB/standalone/log4j.properties a4bcb2e 
>   conf/examples/512MB/standalone/masters 63fb8bb 
>   conf/examples/512MB/standalone/monitor 63fb8bb 
>   conf/examples/512MB/standalone/monitor_logger.xml 3a63bf4 
>   conf/examples/512MB/standalone/slaves 63fb8bb 
>   conf/examples/512MB/standalone/tracers 63fb8bb 
>   conf/examples/crypto/accumulo-site.xml a7e5c54 
>   conf/examples/crypto/readme.txt c638b6e 
>   conf/examples/vfs-classloader/accumulo-site.xml ea95ea2 
>   conf/templates/accumulo-env.sh PRE-CREATION 
>   conf/templates/accumulo-metrics.xml PRE-CREATION 
>   conf/templates/accumulo-site.xml PRE-CREATION 
>   conf/templates/accumulo.policy.example PRE-CREATION 
>   conf/templates/gc PRE-CREATION 
>   conf/templates/generic_logger.xml PRE-CREATION 
>   conf/templates/log4j.properties PRE-CREATION 
>   conf/templates/masters PRE-CREATION 
>   conf/templates/monitor PRE-CREATION 
>   conf/templates/monitor_logger.xml PRE-CREATION 
>   conf/templates/slaves PRE-CREATION 
>   conf/templates/tracers PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18438/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John McNamee
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message