accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 18365: ACCUMULO-2390 InvocationTargetEx in TraceProxy
Date Sun, 23 Feb 2014 19:18:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18365/#review35246
-----------------------------------------------------------



src/trace/src/main/java/org/apache/accumulo/cloudtrace/instrument/TraceProxy.java
<https://reviews.apache.org/r/18365/#comment65700>

    Would much rather have this logged than dumped to STDOUT. Is there a reason not to?



src/trace/src/test/java/org/apache/accumulo/cloudtrace/instrument/TracerTest.java
<https://reviews.apache.org/r/18365/#comment65701>

    The explicit fail call is redundant with the expected argument to the Test annotation.


- Josh Elser


On Feb. 21, 2014, 7:11 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18365/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 7:11 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2390
>     https://issues.apache.org/jira/browse/ACCUMULO-2390
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2390 InvocationTargetEx in TraceProxy
> 
> Handle InvocationTargetException specifically in TraceProxy, instead
> of letting it get propogated up the call stack. In some cases this is
> very bad as it turned into an UndeclaredThrowableException and made
> debugging more difficult than necessary.
> 
> Added unit test to verify behaviour.
> 
> 
> Diffs
> -----
> 
>   src/trace/src/main/java/org/apache/accumulo/cloudtrace/instrument/TraceProxy.java 67c4463429fdacdb4aae1d07d5256a5a4f077552

>   src/trace/src/test/java/org/apache/accumulo/cloudtrace/instrument/TracerTest.java 30b62f9f7d4c0a047a33fd0244b3acd57733b5b1

> 
> Diff: https://reviews.apache.org/r/18365/diff/
> 
> 
> Testing
> -------
> 
> Unit tests run.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message